Uses INT and BIGINT as default 32-bit and 64-bit integer names #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yliuuuu
approved these changes
May 28, 2024
Comment on lines
+48
to
+54
| // TODO: REMOVE ME | ||
| // PartiQL came from Ion SQL which uses the INT name for the unbounded integer. | ||
| // In SQL, the INT name must have some finite precision and most systems use a 32-bit integer. | ||
| // Scribe is built to interface with other systems, so we must change all occurrences of the INT | ||
| // type name with INT4. In short, all systems do INT = INT4 but PartiQL has INT4 != INT. | ||
| // >>>> ISSUE — https://github.com/partiql/partiql-lang-kotlin/issues/1471 | ||
| ast = replaceIntWithInt4(ast) |
There was a problem hiding this comment.
Nice temporary work around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
partiql/partiql-lang-kotlin#1471 and #35
Description of changes:
Scribe had been using INT4 and INT8 for the 32-bit and 64-bit integer names, but our target systems use INT and BIGINT respectively. This PR adds an AST workaround to alias INT to INT4, but then emits INT as the default name for INT/INT4.
Similarly, this PR updates AST output to use BIGINT as the default name rather than INT8.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.