Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Release paseo runtime @ polkadot v1.2.5 #85

Merged
17 commits merged into from
Jul 30, 2024
Merged

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Jun 25, 2024

No description provided.

hbulgarini
hbulgarini previously approved these changes Jun 25, 2024
Copy link
Contributor

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was passing by here and found a small mistake!

spec_name: create_runtime_str!("bridge-hub-polkadot"),
impl_name: create_runtime_str!("bridge-hub-polkadot"),
authoring_version: 1,
spec_version: 1_001_002,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claravanstaden i have just realized about this. Did you forget upgrading the spec version to 1_001_005 or the code is effectively running under 1_001_002?

Copy link
Contributor

@hbulgarini hbulgarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the PR is in a good position to be merged.

@al3mart al3mart closed this pull request by merging all changes into main in 89ee135 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime-upgrade Runtime Upgrade
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants