-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Reference Rework #722
API Reference Rework #722
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
d816255
to
1a5411f
Compare
It's really looking good ! I have a small issue, it seems to me the classes |
Actually, it's all the ABC classes that disappeared. It depends on who we are targetting with the API documentation, but I thought that it would be developpers, that I think would like to see these classes. If it's people that just use pulser, then the current state makes sense, because it only displays the useful classes. |
Ok, this is a discussion we have to have. Btw, I'll be the first to admit that I might not be entirely consistent with this selection criteria for what to expose and what to hide. In general, I just went with what made sense to me. |
I still have issue in properly visualising the pages -.- so my answer will be quite general. I guess @a-corni you make a right point and I believe that the answer should come from answering the following question: which use cases would be covered by exposing the ABC classes? If the ABC classes are there to let people create their own version of a NA QPU, then I would prefer to have them not highlighted. This to me is consistent with the principle we adopted last October which is to make Pulser closer to Pasqal QPU and on a secondary level also a tool to program any NA qpu. A third way maybe is to group them together? A section of ABC classes, would this be possible? |
I agree with both of you, the API documentation should only expose the interface for the user. It is not an issue not to expose the ABC classes because the code is open-source and because the documentation exposes all the functions inherited from the ABC classes. |
pulser-simulation
pulser_pasqal
too