Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33990) feat(auth): log more informations in useSignUp catch error #7627

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

lbeneston-pass
Copy link
Contributor

@lbeneston-pass lbeneston-pass commented Feb 4, 2025

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33990
Link to sentry : https://sentry.passculture.team/organizations/sentry/issues/1046950/?project=6&referrer=jira_integration

J'ai essayé de log plus d'information sur l'erreur, notamment si il s'agit d'une erreur en lien avec le SSO Google ou pas

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident [on Notion][2]

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" [on Notion][1]
  • I am aware of all the best practices and respected them.

Copy link

sonarqubecloud bot commented Feb 4, 2025

@lbeneston-pass lbeneston-pass merged commit f64194d into master Feb 4, 2025
61 checks passed
@lbeneston-pass lbeneston-pass deleted the PC-33990 branch February 4, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants