This repository has been archived by the owner on Dec 30, 2018. It is now read-only.
fix(directive): check for existing elements before appending #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't append elements that Masonry has already added to its items.
| @@ -65,7 +65,10 @@ | |||
| // Keep track of added elements. | |||
| bricks[id] = true; | |||
| defaultLoaded(element); | |||
| $element.masonry(method, element, true); | |||
| // Don't add element to Masonry if it already has it. | |||
| if ($element.masonry('getItemElements').indexOf(element.get(0)) === -1) { | |||
There was a problem hiding this comment.
This would be O(n^2) when adding a list of n new elements, this seems like a very dangerous default. Is there any other way to address this?
There was a problem hiding this comment.
I'm not sure if there's a more "Angular" way of doing this, but within initialization of the masonry directive, it could iterate once through every existing child element and run something like child.data('angularMasonryAdded', true). Then the above code could be changed to check if the element has that data attribute, avoiding per-element iteration. What do you think?
…as static Using jQuery's data functionality, we can mark static elements upon initialization.
Avoid using possibly non-existent global $.
Angular-masonry supports dynamic elements by default; Be explicit in the specs that most cases involve dynamically repeating bricks
|
@passy Fixed the specs to reflect the general use of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't append elements that Masonry has already added to its items.
This fixes the situation in which a static element has already been added to Masonry, but then the
masonrydirective attempts to add a newmasonry-brickinto Masonry's item list.