Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed namespaced attributes not updating #125

Closed
wants to merge 4 commits into from
Closed

fixed namespaced attributes not updating #125

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5996f4
fixed namespaced attributes not updating
AndyOGo Apr 18, 2018
915b90c
fixed missing semis
AndyOGo Apr 18, 2018
a26daa3
just in case local name is not available
AndyOGo Apr 20, 2018
3c8e5fa
movend comments to related api call
AndyOGo Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/morphAttrs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,15 @@ export default function morphAttrs(fromNode, toNode) {
attrValue = attr.value;

if (attrNamespaceURI) {
attrName = attr.localName || attrName;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use || attrName because IE doesn't seem to support .localName see

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback, very appreciated.
About which version of IE are we speaking? (IE9 supports localName, see).
Microsoft officially stopped to support old IE versions until version 11

My point is that the setAttributeNS API is called with the wrong argument and I provided the official W3C specifications. May I ask you to study them yourself, look up all the technical definitions in the official DOM API glossary and then decide for yourself if I'm right or wrong.

fromValue = fromNode.getAttributeNS(attrNamespaceURI, attrName);

var attrLocalName = attr.localName;

// Important: getAttributeNS expects the localName of a namespaced attribute
// but setAttributeNS requires the fully qualified name
// ref: https://dom.spec.whatwg.org/#dom-element-getattributens
// ref: https://www.w3.org/TR/DOM-Level-2-Core/glossary.html#dt-localname
// ref: https://dom.spec.whatwg.org/#dom-element-setattributens
// ref: https://www.w3.org/TR/DOM-Level-2-Core/glossary.html#dt-qualifiedname
fromValue = fromNode.getAttributeNS(attrNamespaceURI, attrLocalName || attrName);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AutoSponge
I just inlined the attrName fallback just for getAttributeNS.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndyOGo are you saying these two blocks are different?

current

attrName = attr.localName || attrName;
fromValue = fromNode.getAttributeNS(attrNamespaceURI, attrName);

this PR

var attrLocalName = attr.localName;
fromValue = fromNode.getAttributeNS(attrNamespaceURI, attrLocalName || attrName);

Because I'm not seeing it. I'm still confused as to exactly what you think this fixes.

Copy link
Author

@AndyOGo AndyOGo Apr 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No with my last commit I restored the original getAttributeNS function call with a fallback to attrName if attr.localName is not defined.

But the line below using setAttributeNS has changed to never use attr.localName.

if (fromValue !== attrValue) {
fromNode.setAttributeNS(attrNamespaceURI, attrName, attrValue);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AutoSponge
Since I don't overwrite attrName with attr.localName || attrName anymore, setAttributeNS will always only use the full qualified attribute name, including it's namespace.

}
Expand Down