Merge pull request #1132 from patrickcate/feature/1131/icon-href-attr…

…ibute feat(UsaIcon): switch from deprecated `xlink:href` attribute to `href`
patrickcate · Jan 12, 2025 · 575698c · 575698c
2 parents 233633e + 7d4b5b0
commit 575698c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/UsaIcon/UsaIcon.test.js b/src/components/UsaIcon/UsaIcon.test.js
@@ -17,7 +17,7 @@ describe('UsaIcon', () => {
 
     cy.get('svg > use').should(
       'have.attr',
-      'xlink:href',
+      'href',
       '/assets/img/sprite.svg#flag',
     )
   })
@@ -44,7 +44,7 @@ describe('UsaIcon', () => {
       .and('have.attr', 'focusable', 'true')
       .and('have.class', 'usa-icon--size-3')
 
-    cy.get('svg > use').should('have.attr', 'xlink:href', '/test.svg#github')
+    cy.get('svg > use').should('have.attr', 'href', '/test.svg#github')
   })
 
   it('custom slot content is used', () => {

diff --git a/src/components/UsaIcon/UsaIcon.vue b/src/components/UsaIcon/UsaIcon.vue
@@ -62,6 +62,6 @@ const iconHref = computed(() => `${svgSpritePath}#${props.name}`)
     :focusable="focusable"
   >
     <slot name="title"></slot>
-    <use :xlink:href="iconHref"></use>
+    <use :href="iconHref"></use>
   </svg>
 </template>