Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dark theme styling): fix ws dark theme styles #3906

Merged
merged 4 commits into from
Mar 21, 2024
Merged

chore(dark theme styling): fix ws dark theme styles #3906

merged 4 commits into from
Mar 21, 2024

Conversation

andrew-ronaldson
Copy link
Contributor

@andrew-ronaldson andrew-ronaldson commented Feb 28, 2024 •
edited
Loading

Closes #3910

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 28, 2024 •
edited
Loading

Preview: https://patternfly-org-pr-3906-site.surge.sh

@andrew-ronaldson andrew-ronaldson linked an issue Feb 29, 2024 that may be closed by this pull request
Fix workspace styling on nav and code blocks. #3910
Closed
@evwilkin evwilkin self-requested a review March 13, 2024 14:56
srambach
srambach approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌔 LGTM

nicolethoen
nicolethoen reviewed Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but then I noticed that at smaller screen widths the expandable jumplinks are looking incorrect in dark theme:
Screenshot 2024-03-19 at 2 14 43 PM
Screenshot 2024-03-19 at 2 14 54 PM

@nicolethoen nicolethoen self-requested a review March 19, 2024 18:15
@nicolethoen
Copy link
Collaborator

after the last change, something wonky is happening to the minified react.
I'm seeing the same weird side effect when I run things locally. I'll see if I can track down what's happening...

@andrew-ronaldson @nicolethoen
chore(typography): remove broken background
bfeb182
@andrew-ronaldson @nicolethoen
Update mdx.css
33a4d13 
changed ws-code to use secondary background color
@andrew-ronaldson @nicolethoen
Update sideNav.css
2e70221 
Background of current nav item in dark theme
@andrew-ronaldson @nicolethoen
Update tableOfContents.css
b601bd3 
changed the background-color on ws-toc
@andrew-ronaldson
Copy link
Contributor Author

Screenshot 2024-03-21 at 10 39 23 AM Noticed this bit of weirdness when the ToC gets expanded. It's working well enough for Alpha but good to fix in a follow up

@nicolethoen nicolethoen merged commit 8ab357e into patternfly:v6 Mar 21, 2024
4 checks passed
@evwilkin
Copy link
Member

FYI the collapsible ToC being cut off bug flagged above looks to be due to this line applying overflow: auto to the component. Removing the line looks to fix the issue, and I cannot confirm if/why that code needs to be present at all, so believe we can simply strip that one line out.

@evwilkin evwilkin mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@srambach srambach srambach approved these changes

@evwilkin evwilkin Awaiting requested review from evwilkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix workspace styling on nav and code blocks.
5 participants
@andrew-ronaldson @patternfly-build @nicolethoen @evwilkin @srambach