docs(get-started): Updates get started contribute pages. #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: In this first pass I tried combining the pages, but this is an idea that I'd like to hear feedback on. Happy to iterate further! also, I know that we plan to enhance/build out on these, so we can do that in this pr or a followup |
srambach
reviewed
Apr 23, 2024
There was a problem hiding this comment.
I like combining the pages. ❤️ I do have some individual comments.
- The Figma kit isn't mentioned - should it be?
- I'm not sure about formatting the repo names as code. It's not really code per se, and it makes it harder to see that those are links.
- In general, I find this page more difficult to scan and understand than the old one, which had a bit less just text and more lists.
packages/documentation-site/patternfly-docs/content/get-started/contribute.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/contribute.md
Outdated
Show resolved
Hide resolved
| - [Core contribution guidelines](https://github.com/patternfly/patternfly#guidelines-for-css-development) | ||
| - [React contribution guidelines](https://github.com/patternfly/patternfly-react/blob/main/CONTRIBUTING.md#contribution-process) | ||
|
|
||
| ### File a bug |
There was a problem hiding this comment.
I find the old version with the bullets a lot easier to read.
|
@srambach made some updates from your feedback - ty! RE contributing to the Figma kit - is there an established process for this yet? |
srambach
approved these changes
May 21, 2024
jessiehuff
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3921