Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): update beta button style #3961

Merged
merged 3 commits into from
May 2, 2024
Merged

feat(docs): update beta button style #3961

merged 3 commits into from
May 2, 2024

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Apr 11, 2024

Closes #3859.

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 11, 2024 •
edited
Loading

Preview: https://patternfly-org-pr-3961-site.surge.sh

@kmcfaul kmcfaul linked an issue Apr 15, 2024 that may be closed by this pull request
Beta label styling issues #3859
Closed
@jessiehuff jessiehuff requested a review from mcoker April 23, 2024 15:15
mcoker
mcoker approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small change unless there is a reason you think we should leave it as is.

packages/documentation-framework/templates/mdx.js Outdated Show resolved Hide resolved
mcoker
mcoker approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

wise-king-sullyman
wise-king-sullyman approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jessiehuff jessiehuff merged commit 8a68ab7 into v6 May 2, 2024
4 checks passed
@nicolethoen nicolethoen deleted the beta-button branch June 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker approved these changes

@jessiehuff jessiehuff jessiehuff approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beta label styling issues
5 participants
@kmcfaul @patternfly-build @wise-king-sullyman @jessiehuff @mcoker