Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SearchInput): advanced search aria-expanded set by default #11494

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

nicolethoen
Copy link
Contributor

What: Closes #11399

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 3, 2025

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🎉 Could we just add a couple of tests that checks that aria-expanded is rendered false by default on the toggle button for an advanced search input, then is true when isAdvancedSearchOpen is true?

@nicolethoen
Copy link
Contributor Author

yes!

@thatblindgeye thatblindgeye merged commit 64842c0 into patternfly:main Feb 13, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - SearchInput - advanced example toggle does not have aria-expanded by default
4 participants