Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade golang from 1.15.1 to 1.23.4 #291

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
60ff255
NO-ISSUE: Opening PR for ACM 2.9 Images (#5486)
CrystalChun Sep 14, 2023
263f067
XMGMT-15704 - Bugfix for local cluster import (#5491)
openshift-cherrypick-robot Sep 18, 2023
a3cd274
MGMT-15501: ClusterServiceVersion for release 2.9 branch references "…
eliorerz Sep 26, 2023
236b17a
MGMT-15559: Change detached annotation condition in non-converged flo…
openshift-cherrypick-robot Sep 27, 2023
433d225
NO-ISSUE: Fix email domain for event uploader (#5526)
openshift-cherrypick-robot Oct 3, 2023
b692336
NO-ISSUE: Add versions file to onprem event upload (#5527)
openshift-cherrypick-robot Oct 4, 2023
9dddb39
NO-ISSUE: fail upload if response is not 2XX (#5535)
openshift-cherrypick-robot Oct 5, 2023
5f5beed
MGMT-15507: Set restricted list of approvers for protected release-oc…
eliorerz Oct 9, 2023
d8fb86d
[release-ocm-2.9] MGMT-14409: generate short image URL (#5541)
openshift-cherrypick-robot Oct 9, 2023
0782a61
MGMT-15507: Add adriengentil as approver in ocm-2.9 (#5542)
adriengentil Oct 10, 2023
0d5f766
WIP: Add assisted images service short URL routes (#5545)
openshift-cherrypick-robot Oct 10, 2023
664e793
MGMT-15306: Fix UpdateCluster for requests that include VIPS and UMA …
openshift-cherrypick-robot Oct 15, 2023
513365c
MGMT-15572 Hold installation when reconcile-pause annotation is set o…
openshift-cherrypick-robot Oct 18, 2023
0aa5908
MGMT-15980: added missing Create op to infraenvs Webhook (#5577)
openshift-cherrypick-robot Oct 22, 2023
901f36b
MGMT-15949: fix missing ImageSetRef validation (#5574)
openshift-cherrypick-robot Oct 22, 2023
58f033a
NO-ISSUE: Disable local cluster import in ACM 2.9 (#5587)
paul-maidment Oct 24, 2023
fbf68fe
MGMT-16045: mitigate CVE-2023-44487 (#5614) (#5623)
rccrdpccl Oct 26, 2023
fe48f6f
MGMT-16039: upgrade to golang 1.20 (#5627)
rccrdpccl Oct 27, 2023
ae1c511
MGMT-15680: Adds InfraEnv ctrl watch for pull secret changes (#5656)
openshift-cherrypick-robot Nov 5, 2023
810c55a
MGMT-16052: Fix cluster HighAvailabilityMode nil pointer in update fl…
openshift-cherrypick-robot Nov 6, 2023
e82242d
MGMT-16001: Sanitize reclaim daemonset name (#5643)
openshift-cherrypick-robot Nov 6, 2023
0531d47
Add missing scheme to `ServiceMonitor` (#5686)
openshift-cherrypick-robot Nov 14, 2023
628a95f
MGMT-16001: Sanitize reclaim agent daemonset name (#5727)
openshift-cherrypick-robot Nov 22, 2023
379690e
MGMT-16047: update baremetal-operator to 4.14 (#5735)
filanov Nov 27, 2023
16ae42e
MGMT-16312 fix update host ignition for unbound host (#5761)
openshift-cherrypick-robot Dec 3, 2023
4817869
NO-ISSUE: fix golangci-lint failing to be pulled (#5800)
openshift-cherrypick-robot Dec 11, 2023
f965b6c
[release-ocm-2.9] MGMT-16312: changing dnsmasq configuration for sno…
tsorya Dec 11, 2023
a211ac4
Compare normalized infraenv and preprov image architectures (#5823)
openshift-cherrypick-robot Dec 24, 2023
aa1d952
OCPBUGS-25434: handle NMStateConfig deletion (#5846)
openshift-cherrypick-robot Dec 26, 2023
b089c14
MGMT-16494: Move ip hint file creation to ignition in order to change…
openshift-cherrypick-robot Jan 16, 2024
bb1dc5f
OCPBUGS-27376: Allow domain names starting with a number (#5914) (#5936)
CrystalChun Jan 31, 2024
42cb4f1
MGMT-14226: Upgrade docker to 20.10.24 for CVE-2023-28842 (#5951) (#5…
CrystalChun Feb 8, 2024
fdb1176
ACM-9504: Remove unecessary dependency on go-git (#5913) (#5970)
CrystalChun Feb 9, 2024
0902b72
ACM-9504: CVE-2023-49568, CVE-2023-49569 - Remove dependency on go-git
paul-maidment Feb 14, 2024
f272ddb
fix: vendor/github.com/go-gormigrate/gormigrate/v2/Dockerfile to redu…
snyk-bot Dec 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
4 changes: 2 additions & 2 deletions Dockerfile.assisted-service
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ COPY tools/generate_python_client.sh .
RUN chmod +x ./generate_python_client.sh && SWAGGER_FILE=swagger.yaml OUTPUT=/build ./generate_python_client.sh

# TODO: Find a pure Python3 base image, rather than relying on the golang one
FROM registry.ci.openshift.org/openshift/release:golang-1.18 as pybuilder
FROM registry.ci.openshift.org/openshift/release:golang-1.20 as pybuilder
COPY . /assisted-service
COPY --from=swagger_py /build /assisted-service/build
RUN python3 -m pip install -I pip && pip3 install -I -r /assisted-service/dev-requirements.txt
Expand All @@ -17,7 +17,7 @@ RUN cd /assisted-service/build && python3 ../tools/client_package_initializer.py
FROM quay.io/centos/centos:stream8 as builder

RUN dnf install --enablerepo=powertools -y gcc git nmstate-devel && dnf clean all
COPY --from=registry.ci.openshift.org/openshift/release:golang-1.18 /usr/local/go /usr/local/go
COPY --from=registry.ci.openshift.org/openshift/release:golang-1.20 /usr/local/go /usr/local/go

ENV GOROOT=/usr/local/go
ENV PATH=$PATH:$GOROOT/bin
Expand Down
5 changes: 2 additions & 3 deletions Dockerfile.assisted-service-build
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.ci.openshift.org/openshift/release:golang-1.18 AS golang
FROM registry.ci.openshift.org/openshift/release:golang-1.20 AS golang
RUN chmod g+xw -R /usr/local/go

FROM quay.io/centos/centos:stream8
Expand All @@ -10,8 +10,7 @@ ENV VIRTUAL_ENV=/opt/venv
ENV TOOLS=/tools/
ENV PATH="$VIRTUAL_ENV/bin:$GOROOT/bin:$GOPATH/bin:$TOOLS:$PATH"

COPY --from=quay.io/app-sre/golangci-lint:v1.46.0 /usr/bin/golangci-lint /usr/bin/golangci-lint

RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b /usr/bin v1.53.2
# TODO: Replace with version 0.30.4 once it is released.
#
# We need version 5d0a00d of go-swagger because it is the first that contains
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ endif
# Operator Vars - these must be kept up to date
BUNDLE_CHANNELS ?= alpha,ocm-2.9
BUNDLE_OUTPUT_DIR ?= deploy/olm-catalog
BUNDLE_METADATA_OPTS ?= --channels=$(BUNDLE_CHANNELS) --default-channel=alpha
BUNDLE_METADATA_OPTS ?= --channels=$(BUNDLE_CHANNELS) --default-channel=ocm-2.9

# We decided to have an option to change replicas count only while running locally
# check if SERVICE_REPLICAS_COUNT was set and if yes change default value to required one
Expand Down
24 changes: 1 addition & 23 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,9 @@
aliases:
approvers:
- romfreiman
- avishayt
- eranco74
- oourfali
- filanov
- gamli75
- ori-amizur
- tsorya
- nmagnezi
- carbonin
- danielerez
- omertuc
- eliorerz
- osherdp
- vrutkovs
- paul-maidment
- jhernand
- rccrdpccl
- adriengentil
- CrystalChun
- javipolo
- danmanor
emeritus_approvers:
- empovit
- yevgeny-shnaidman
- rwsu
- lranjbar
- pawanpinjarkar
- sagidayan
- ybettan
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ To push your build target to a Docker registry you first need to change the defa
1. Login to quay.io using `docker login quay.io`.
1. Export the `SERVICE` environment variable to your Docker registry, and pass a tag of your choice, e.g., "test":

```sh
```shell
export SERVICE=quay.io/<username>/assisted-service:<tag>
```

Expand Down
4 changes: 2 additions & 2 deletions api/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ require (
github.com/pkg/errors v0.9.1 // indirect
github.com/thoas/go-funk v0.9.2 // indirect
go.mongodb.org/mongo-driver v1.10.0 // indirect
golang.org/x/net v0.14.0 // indirect
golang.org/x/text v0.12.0 // indirect
golang.org/x/net v0.17.0 // indirect
golang.org/x/text v0.13.0 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
Expand Down
10 changes: 5 additions & 5 deletions api/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,8 @@ golang.org/x/net v0.0.0-20211015210444-4f30a5c0130f/go.mod h1:9nx3DQGgdP8bBQD5qx
golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
golang.org/x/net v0.0.0-20211209124913-491a49abca63/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd/go.mod h1:CfG3xpIq0wQ8r1q4Su4UZFWDARRcnwPjda9FqA0JpMk=
golang.org/x/net v0.14.0 h1:BONx9s002vGdD9umnlX1Po8vOZmrgH34qlHcD1MfK14=
golang.org/x/net v0.14.0/go.mod h1:PpSgVXXLK0OxS0F31C1/tv6XNguvCrnXIDrFMspZIUI=
golang.org/x/net v0.17.0 h1:pVaXccu2ozPjCXewfr1S7xza/zcXTity9cCdXQYSjIM=
golang.org/x/net v0.17.0/go.mod h1:NxSsAGuq816PNPmqtQdLE42eU2Fs7NoRIZrHJAlaCOE=
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
Expand Down Expand Up @@ -327,7 +327,7 @@ golang.org/x/sys v0.0.0-20210831042530-f4d43177bf5e/go.mod h1:oPkhp1MJrh7nUepCBc
golang.org/x/sys v0.0.0-20211019181941-9d821ace8654/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.0.0-20220209214540-3681064d5158/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.11.0 h1:eG7RXZHdqOJ1i+0lgLgCpSXAp6M3LYlAo6osgSi0xOM=
golang.org/x/sys v0.13.0 h1:Af8nKPmuFypiUBjVoU9V20FiaFXOcuZI21p0ycVYYGE=
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
Expand All @@ -336,8 +336,8 @@ golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/text v0.3.5/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
golang.org/x/text v0.12.0 h1:k+n5B8goJNdU7hSvEtMUz3d1Q6D/XW4COJSJR6fN0mc=
golang.org/x/text v0.12.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
golang.org/x/text v0.13.0 h1:ablQoSUd0tRdKxZewP80B+BaqeKJuVhuRxj/dkrun3k=
golang.org/x/text v0.13.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
golang.org/x/tools v0.0.0-20190114222345-bf090417da8b/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
golang.org/x/tools v0.0.0-20190226205152-f727befe758c/go.mod h1:9Yl7xja0Znq3iFh3HoIrodX9oNMXvdceNzlUR8zjMvY=
Expand Down
51 changes: 0 additions & 51 deletions api/vendor/golang.org/x/net/http2/Dockerfile

This file was deleted.

3 changes: 0 additions & 3 deletions api/vendor/golang.org/x/net/http2/Makefile

This file was deleted.

86 changes: 70 additions & 16 deletions api/vendor/golang.org/x/net/http2/server.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions api/vendor/golang.org/x/net/http2/transport.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/vendor/golang.org/x/text/unicode/norm/trie.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@ go.mongodb.org/mongo-driver/bson/bsonrw
go.mongodb.org/mongo-driver/bson/bsontype
go.mongodb.org/mongo-driver/bson/primitive
go.mongodb.org/mongo-driver/x/bsonx/bsoncore
# golang.org/x/net v0.14.0
# golang.org/x/net v0.17.0
## explicit; go 1.17
golang.org/x/net/http/httpguts
golang.org/x/net/http2
golang.org/x/net/http2/hpack
golang.org/x/net/idna
# golang.org/x/text v0.12.0
# golang.org/x/text v0.13.0
## explicit; go 1.17
golang.org/x/text/secure/bidirule
golang.org/x/text/transform
Expand Down
4 changes: 2 additions & 2 deletions ci-images/Dockerfile.base
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ RUN dnf install -y 'dnf-command(config-manager)' && \
# running with a random user.
RUN git config --system --add safe.directory '*'

COPY --from=registry.ci.openshift.org/openshift/release:golang-1.18 /usr/local/go /usr/local/go
COPY --from=registry.ci.openshift.org/openshift/release:golang-1.18 /usr/bin/gotestsum /usr/bin/make /usr/bin/
COPY --from=registry.ci.openshift.org/openshift/release:golang-1.20 /usr/local/go /usr/local/go
COPY --from=registry.ci.openshift.org/openshift/release:golang-1.20 /usr/bin/gotestsum /usr/bin/make /usr/bin/

ENV GOPATH=/go
ENV GOROOT=/usr/local/go
Expand Down
2 changes: 1 addition & 1 deletion ci-images/Dockerfile.lint
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM base

COPY --from=quay.io/app-sre/golangci-lint:v1.46.0 /usr/bin/golangci-lint /usr/bin/golangci-lint
RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b /usr/bin v1.53.2
COPY --from=quay.io/coreos/shellcheck-alpine:v0.5.0 /bin/shellcheck /usr/bin/shellcheck

RUN dnf install -y diffutils
Loading