-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User authentication and different accounts #48
base: main
Are you sure you want to change the base?
Conversation
Note that currently this is UNSAFE, since the Currently there is an issue where if you update your own username, your credentials will no longer be valid. To fix this I could update the token automatically when this occurs (?). For anyone who wants to test this, the default user has username Note that, so far, this change can only really be tested in the Swagger docs of Jetlog (automatically generated in |
The latest commit supports a very basic but functional authentication system, which allows only authenticated users to access Jetlog. Next, each user should have a personalized view of Jetlog with only the flights/data relevant to them. The current state of the code is somewhat janky, and some things that I need to work on next are:
As progress for this feature moves forward, I am realizing that there are quite a few aspects of the code that I would like to change, for example:
If anyone is reading this, I apologize for the long wait on this feature. I have been quite busy lately, and I don't see that changing very soon, which unfortunately means that updates will keep coming out at a slow rate. I'm doing my best to find the time to work on Jetlog. |
Aside from user management for admins, the bare functionality of this feature has mostly been implemented. Users are now able to log in and view/edit/delete/create ONLY their flights. Some things missing from the latest commits, aside from UI improvements, are:
|
Something I need to decide is how to handle the creation of the first user. Currently the first user is created by default and has username and password |
Reminder to self: remove "Edit" and "Delete" buttons for normal (non-admin) users viewing someone else's flight |
Closes #43
Closes #26
This pull request aims to implement OAuth2 authentication (FastAPI docs) by implementing the following functionality:
users
database tableSECRET_KEY
from (docker) environment