Communication graph and Gantt chart #6

Mellich · 2023-02-21T13:10:58Z

This PR does the following changes:

Extend MPIEvent with an end time to allow the generation of a Gantt chart (Gantt Chart #3)
Adds functionality to generate a communication graph from a merged tape
Primitive plotting functions for Gantt charts and arrows to reflect communication between ranks

carstenbauer · 2023-02-21T15:29:02Z

example/mpi_trapezoidal.jl

@@ -86,6 +86,8 @@ MPITape.print_mytape()
 tape_merged = MPITape.merge()
 if rank == 0 # Master
    MPITape.print_merged(tape_merged)
+    display(MPITape.plot_merged(tape_merged))
+    readline()


The plot isn't interactive, right? Might be better to just directly save as png/pdf.

carstenbauer · 2023-02-21T15:31:25Z

src/communication_graph.jl

+
+function srcdest_to_rankarray(srcdest, rank)
+    if srcdest in ["all", "each", "some"]
+        return vcat(collect(0:getcommsize()-1))


Das vcat ist hier überflüssig, oder nicht?

Ist wahrscheinlich auch nicht ganz korrekt, da z.B. bei "some" nicht alle ranks involviert sind (siehe z.B. MPI_Scan). Hängt aber auch einfach davon ab wie genau wir das darstellen wollen.

Ja, das müssen wir irgendwann sicher noch einmal umbauen - insbesondere, wenn wir communicators unterstützen wollen. Für die meisten collectives reicht es im Moment aber, denke ich.

carstenbauer · 2023-02-21T15:32:20Z

src/communication_graph.jl

+    if typeof(srcdest) <: Integer
+        return [srcdest]
+    end
+    if srcdest == nothing


isnothing(srcdest) ist eleganter / besser.

carstenbauer · 2023-02-21T15:32:27Z

src/communication_graph.jl

+
+function MPIEventNeighbors(ev::MPIEvent)
+    srcdest = getsrcdest(ev)
+    if srcdest == nothing


isnothing(srcdest) ist eleganter / besser.

carstenbauer · 2023-02-21T15:34:08Z

src/communication_graph.jl

+    opendsts = srcdest_to_rankarray(srcdest[:dest], ev.rank)
+    # Delete rank from recvs or sends it if is root!
+    if length(opensrcs) == 1 && (opensrcs[1] in opendsts)
+        deleteat!(opendsts, findfirst(x->x==opensrcs[1], opendsts))


Tipp: findfirst(x->x==opensrcs[1], opendsts) kannst du auch als findfirst(isequal(opensrcs[1]), opendsts) schreiben.

carstenbauer · 2023-02-21T15:35:06Z

src/communication_graph.jl

+        srcdest = (src = nothing, dest = nothing)
+    end
+    opensrcs = srcdest_to_rankarray(srcdest[:src], ev.rank)
+    opendsts = srcdest_to_rankarray(srcdest[:dest], ev.rank)


Würde vielleicht opendsts in opendests umbenennen, damit wir einheitlich source als src und destination als dest abkürzen.

carstenbauer · 2023-02-21T15:36:33Z

src/communication_graph.jl

+    # Construct data structure for linked list of MPI calls
+    for e in tape
+        push!(open_links, MPIEventNeighbors(e))
+    end


Direkt open_links = MPIEventNeighbors[MPIEventNeighbors(e) for e in tape] ?

carstenbauer · 2023-02-21T15:40:31Z

src/mpievent.jl

+    if isempty(ev.args_subset)
+        return nothing
+    end
+    if haskey(ev.args_subset, :tag)


Verstehe die tag Geschichte nicht ganz. Ist haskey(ev.args_subset, :tag) aktuell nicht einfach immer false?

Ich nutze die Funktion beim Matchen der MPI Events. Im Moment hat sie keinen Effekt, da sie immer nothing zurück gibt, aber sobald wir tags in unserem NamedTuple hinzufügen, sollten sie damit auch direkt berücksichtigt werden.

Mellich · 2023-02-21T17:22:30Z

I also added support for #1 with the function plot_sequence_merged. It is possible to output the graph directly in the terminal.

carstenbauer · 2023-02-21T18:15:09Z

Looks nice! I was first slightly confused that there are no MPI_Recvs. :)

BTW, there is a dropmpiprefix function (or similar) that drops the "MPI_" part from the function names. Should look a lot cleaner with this.

     ┌──────┐          ┌──────┐          ┌──────┐          ┌──────┐          ┌──────┐
     │Rank_0│          │Rank_1│          │Rank_2│          │Rank_4│          │Rank_3│
     └──┬───┘          └──┬───┘          └──┬───┘          └──┬───┘          └──┬───┘
        │     MPI_Send    │                 │                 │                 │
        │ ────────────────>                 │                 │                 │
        │                 │                 │                 │                 │
        │              MPI_Send             │                 │                 │
        │ ──────────────────────────────────>                 │                 │
        │                 │                 │                 │                 │
        │     MPI_Send    │                 │                 │                 │
        │ ────────────────>                 │                 │                 │
        │                 │                 │                 │                 │
        │                 │     MPI_Send    │                 │                 │
        │ ────────────────────────────────────────────────────>                 │
        │                 │                 │                 │                 │
        │              MPI_Send             │                 │                 │
        │ ──────────────────────────────────>                 │                 │
        │                 │                 │                 │                 │
        │                 │     MPI_Send    │                 │                 │
        │ ────────────────────────────────────────────────────>                 │
        │                 │                 │                 │                 │
        │                 │              MPI_Send             │                 │
        │ ──────────────────────────────────────────────────────────────────────>
        │                 │                 │                 │                 │
        │                 │              MPI_Send             │                 │
        │ ──────────────────────────────────────────────────────────────────────>
        │                 │                 │                 │                 │
        │                 │     MPI_Send    │                 │                 │
        │ ────────────────────────────────────────────────────>                 │
        │                 │                 │                 │                 │
        │     MPI_Send    │                 │                 │                 │
        │ ────────────────>                 │                 │                 │
        │                 │                 │                 │                 │
        │                 │              MPI_Send             │                 │
        │ ──────────────────────────────────────────────────────────────────────>
        │                 │                 │                 │                 │
        │              MPI_Send             │                 │                 │
        │ ──────────────────────────────────>                 │                 │
        │                 │                 │                 │                 │
        │     MPI_Send    │                 │                 │                 │
        │ <────────────────                 │                 │                 │
        │                 │                 │                 │                 │
        │              MPI_Send             │                 │                 │
        │ <──────────────────────────────────                 │                 │
        │                 │                 │                 │                 │
        │                 │              MPI_Send             │                 │
        │ <──────────────────────────────────────────────────────────────────────
        │                 │                 │                 │                 │
        │                 │     MPI_Send    │                 │                 │
        │ <────────────────────────────────────────────────────                 │
     ┌──┴───┐          ┌──┴───┐          ┌──┴───┐          ┌──┴───┐          ┌──┴───┐
     │Rank_0│          │Rank_1│          │Rank_2│          │Rank_4│          │Rank_3│
     └──────┘          └──────┘          └──────┘          └──────┘          └──────┘

Mellich added 20 commits February 21, 2023 09:17

Add end time to MPIEvent struct

4f4b145

Change getsrcdest to be usable on remote host

183bc87

Add getcommsize helper function

bc87e89

Add getsrcdest for Bcast

508b590

Add gettag for Send,recv,bcast

9ec26b2

Add communication graph generator

fd0f497

Add basic plotting functionality

720e2a7

Add graph plot to example

ab177c1

Add Bcast plot example

ad18bf2

Fix edge generator

08baf24

Add graph example to readme

82aa30b

Show graph in readme

f10e249

Merge remote-tracking branch 'origin/main'

0013ef2

Fix MPIEvent field names

d0cb459

Fix edge generator for new code arch

cedb86e

Fix MPIEvent field names

b0e2dc1

Rename plot function

f2b6ef2

Remove redundant example code

396aa73

Fix graph generation issues with collectives

7d0fabb

Remove unnecessary mutable from struct

08bb339

Mellich requested a review from carstenbauer February 21, 2023 13:11

Mellich added 2 commits February 21, 2023 14:50

Delete invalid edges from parsed srcdest

0e5406a

Add support for sequence diagrams

56649cc

carstenbauer reviewed Feb 21, 2023

View reviewed changes

Mellich added 5 commits February 21, 2023 18:01

Store gantt chart to file in examples

e0cba9e

Refactor code according to review

388a0af

Save plot instead of returning

2648ddc

Remove duplicate edges that do not involve local rank

7c06b08

Refactoring open_links

858df9c

Mellich added 3 commits February 28, 2023 18:16

Merge branch 'main' into 03-gantt

df32bfe

Refactoring and docs of plotting parts

e1d2579

Add tests for plotting

a7bcc8c

Mellich force-pushed the 03-gantt branch from 35569af to 9d3e792 Compare February 28, 2023 18:05

Fix formatting

9945e0b

Mellich force-pushed the 03-gantt branch from 9d3e792 to 9945e0b Compare February 28, 2023 18:13

Mellich merged commit 82b9a27 into pc2:main Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Communication graph and Gantt chart #6

Communication graph and Gantt chart #6

Mellich commented Feb 21, 2023

carstenbauer Feb 21, 2023

carstenbauer Feb 21, 2023

Mellich Feb 21, 2023

carstenbauer Feb 21, 2023

carstenbauer Feb 21, 2023

carstenbauer Feb 21, 2023

carstenbauer Feb 21, 2023

carstenbauer Feb 21, 2023

carstenbauer Feb 21, 2023

Mellich Feb 21, 2023

Mellich commented Feb 21, 2023

carstenbauer commented Feb 21, 2023 •

edited

Loading

Communication graph and Gantt chart #6

Communication graph and Gantt chart #6

Conversation

Mellich commented Feb 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mellich commented Feb 21, 2023

carstenbauer commented Feb 21, 2023 • edited Loading

carstenbauer commented Feb 21, 2023 •

edited

Loading