Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fuzzer for the new, much more complex FFT implementation #182

Closed

Conversation

Shnatsel
Copy link
Contributor

No description provided.

@Shnatsel
Copy link
Contributor Author

No issues after 10 million executions.

I've run it without overflow checks and debug assertions, however. I was only interested in release-mode panics and memory safety issues.

@pdeljanov
Copy link
Owner

I've reworked the rustfft integration in master so that it's only used internally by the Imdct. This is because using it for Fft forces a SemVer breaking change. In v0.6 I'll switch Fft over.

Aside from that, don't you think fuzzing rustfft should be done in the rustfft repo?

@Shnatsel
Copy link
Contributor Author

Shnatsel commented Feb 4, 2023

I'm working on fuzzing in the RustFFT repo, yes: ejmahler/RustFFT#110

But since you said that Symphonia uses RustFFT in specific and limited ways, I thought it might be a good idea to fuzz that codepath first, which should be simpler than the general case.

The RustFFT APIs are more complicated and I still haven't built a working fuzzer in the upstream repo. I could move this code there, if you wish.

@pdeljanov pdeljanov deleted the branch pdeljanov:experimental-opts February 27, 2024 03:42
@pdeljanov pdeljanov closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants