[TASK-8097] feat: order wallet cards

[jjramirezn]

First peanut wallet, then external wallets by date created

Summary by CodeRabbit

• New Features
  • Enhanced wallet sorting mechanism to prioritize Peanut Wallets at the top of the list
  • Wallets now sorted by type and creation date for improved user experience

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 15, 2025 1:57am

[coderabbitai]

Walkthrough

The pull request introduces a sorting mechanism for wallet arrays in the WalletProvider component. The new implementation prioritizes PEANUT_WALLET type wallets by placing them at the beginning of the list, with subsequent wallets sorted by their creation timestamp. This change modifies the order of wallet processing without altering the core functionality of wallet fetching or balance calculations.

Changes

File	Change Summary
src/context/walletContext/walletContext.tsx	Added sorting logic for processedWallets array, prioritizing PEANUT_WALLET type wallets and sorting by created_at timestamp

Poem

🥜 Wallets dancing in a line,
Peanut first, by time's design!
Sorted with algorithmic grace,
Each wallet finds its rightful place
A rabbit's code, both smart and fine 🐰

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[notion-workspace]

🪲 Bug: Peanut Wallet should be always the first being shown on homepage, even if others wallets are connected.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/context/walletContext/walletContext.tsx (1)

113-122: Improve the sorting implementation for better maintainability and robustness.

The current sorting logic can be enhanced in several ways:

- .sort((a, b) => {
-     if (interfaces.AccountType.PEANUT_WALLET === a.account_type) {
-         return -1
-     } else if (interfaces.AccountType.PEANUT_WALLET === b.account_type) {
-         return 1
-     }
-     const dateA = new Date(a.created_at)
-     const dateB = new Date(b.created_at)
-     return dateA.getTime() - dateB.getTime()
- })
+ // Extract the sort function for better maintainability
+ const sortWallets = useMemo(() => (a: typeof user.accounts[0], b: typeof user.accounts[0]) => {
+     // Simplify the Peanut wallet comparison
+     if (a.account_type !== b.account_type) {
+         return a.account_type === interfaces.AccountType.PEANUT_WALLET ? -1 : 1
+     }
+     // Handle potential invalid dates
+     const dateA = new Date(a.created_at).getTime()
+     const dateB = new Date(b.created_at).getTime()
+     return isNaN(dateA) || isNaN(dateB) ? 0 : dateA - dateB
+ }, [])
+ 
+ // Use the memoized sort function
+ .sort(sortWallets)

This refactor:

1. Extracts the sort function for better maintainability
2. Simplifies the Peanut wallet comparison
3. Handles potential invalid dates
4. Memoizes the sort function to prevent unnecessary re-sorting

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd007b3 and 0446e95.

📒 Files selected for processing (1)

• src/context/walletContext/walletContext.tsx (1 hunks)

🔇 Additional comments (1)

src/context/walletContext/walletContext.tsx (1)

113-122: Add tests for the wallet sorting logic.

To ensure the sorting behavior remains correct, consider adding unit tests that verify:

1. Peanut wallets are always sorted first
2. Non-Peanut wallets are correctly sorted by creation date
3. The sorting handles edge cases (invalid dates, missing properties)

Would you like me to help create the test cases for the sorting logic?

[Hugo0]

Logic looks good. Can you double check that we also use this in the wallet header, not just in home screen cards?

[jjramirezn]

Wallet header uses the same wallet list from the wallet context so it should also be ordered