fix: define project env on compile-time

peapescarte · Sep 9, 2024 · d8f6ff4 · d8f6ff4
1 parent e17ec73
commit d8f6ff4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -145,10 +145,9 @@ jobs:
         uses: docker/build-push-action@v6
         with:
           context: .
-          from: ./Dockerfile
           push: true
           tags: ${{ env.IMAGE_NAME }}:dev
-          build-args: MIX_ENV="dev"
+          build-args: MIX_ENV=dev
           target: builder
 
       - name: Generate artifact attestation
@@ -182,7 +181,6 @@ jobs:
         uses: docker/build-push-action@v6
         with:
           context: .
-          from: ./Dockerfile
           push: true
           tags: ${{ env.IMAGE_NAME }}:prod
 

diff --git a/lib/pescarte.ex b/lib/pescarte.ex
@@ -1,6 +1,8 @@
 defmodule Pescarte do
+  @environment Application.compile_env!(:pescarte, :env)
+
   def env do
-    Application.get_env(:pescarte, :env)
+    @environment
   end
 
   def get_static_file_path(folder, file) do

diff --git a/lib/pescarte/application.ex b/lib/pescarte/application.ex
@@ -33,10 +33,5 @@ defmodule Pescarte.Application do
       Pescarte.Supabase,
       {Finch, name: PescarteHTTPClient}
     ]
-    |> maybe_append_children(Pescarte.env())
   end
-
-  defp maybe_append_children(children, :test), do: children
-  # defp maybe_append_children(children, _), do: [ChromicPDF | children]
-  defp maybe_append_children(children, _), do: children
 end