Possible fix for #3, plus CS fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saltybeagle
added a commit
that referenced
this pull request
Feb 7, 2012
Possible fix for #3, plus CS fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a fix for #3, in that in the presense of other autoloaders, an exception will not be thrown.
I'm not sure how to write a test for that though, since there isn't a test that triggers the current exception with only the one autoloader (they trigger fatal errors instead).
I've also fixed most CS issues (missing docs, long lines...). The ones remaining are "conditional include...; use include instead" ones, but I'm not entirely sure of the implications, so I've left those intact.
edit: While I'm at it, I noticed loadSuccessful() could be improved.