-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templating #23
base: main
Are you sure you want to change the base?
Templating #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, thank you!
I think the main thing we can improve here is using Jinja's template inheritance, so that we don't need to repeat the header, navbar, footer, etc. everywhere. See, https://jinja.palletsprojects.com/en/3.1.x/templates/#template-inheritance
Other than that, I think the contents of style.css
should probably be moved to style.scss. I see this PR just copies how it was done in the front-end repo, @redstarblanket is there any specific reason for this?
Also, for future reference, when building on other's work, there's a tag we can use to document that! You just need to add the Co-authored-by
tag to the commit body, which can also be repeated if there's more than one other people. I can do this when I merge this PR, if I select the "squash and merge" option, so don't worry about it for this PR.
Co-authored-by: Em <[email protected]>
(email taken from https://github.com/peepo-world/frontend/commit/5718097a65cefa305a33a4ff5282357ef329457a.patch)
You can find more at https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors.
Not related to this PR, but I just wanted to note here for the future. We should probably add a Jinja+HTML formatter, like https://www.djlint.com/, to pre-commit.
We should also have a "playground", essentially a simple webserver that just renders the templates with dummy data, allowing people to work on the front-end without having to setup the whole project (database, object storage server, etc.).
@import "node_modules/bulma/sass/utilities/initial-variables"; | ||
|
||
|
||
|
||
@import "node_modules/bulma/bulma"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing for you to do here, but I just wanted to note that I plan to change this to use git submodules node, like in https://github.com/FFY00/ffy00.github.io/.
Add templates from frontend repo and basic routes for them. Probably worth adding a base template for navbar/footer.