added supertrend indicator

[kitt-th]

Hi @peerchemist , I added the supertrend indicator. I cross checked results with the original pinescript indicator linked in the indicator description.

black also reformatted some of the comments/lines in finta.py

new code is on lines 1408-1466

this is my first git pull request, so I hope I did it right. let me know what you think!

[peerchemist]

Thanks for the contribution. Unfortunately I will not be able to review before Monday.

[kitt-th]

no problem!

…

On Fri, 4 Dec 2020 at 16:25, peerchemist ***@***.***> wrote: Thanks for the contribution. Unfortunately I will not be able to review before Monday. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#104 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJWB6LVMI5SG4KUZYMWENTDSTD5MXANCNFSM4UNFIBJQ> .

[peerchemist]

Please add unit test.

[kitt-th]

NP will get to that. and submit.

[arul67800]

This formula has errors.. you cannot start the range from 1, since st_data values start after atr period+ supertrend period

[kitt-th]

@arul67800 - thanks for pointing that out. The range should start at 'period +1' as supertrend calculations reference the value of the previous time series/candle. Updated commit coming next.

[peerchemist]

Hi, you are trying to push some weird dotfiles in the tests directory.

tests/data/.DS_Store

[kitt-th]

Hi, sorry about that - my first pull requests so I will check all the files again, clean up and commit without those extra things. Thanks for your patience. I must have made a mistake when adding files.

[ph4z]

Hi,
@peerchemist It seems the PR has been cleaned by @kitt-th
I would like to test this indicator, so it would be nice if you can merge it to the master.
By the way I would be very intrested by the 'megatrend' indicator. Unfortunately I couldn't find the or source/formula for it...

[peerchemist]

Unfortunately this indicator did not work for me in my tests, and I did not have time in a good while to play and hack on it.

[kitt-th]

Did it not work for you with results not being as expected or was there some other error? @peerchemist