-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update empyrion eggs and readme #149
base: main
Are you sure you want to change the base?
Conversation
changed uuid Co-authored-by: MartinOscar <[email protected]>
@@ -132,10 +132,10 @@ | |||
"name": "WINETRICKS_RUN", | |||
"description": "", | |||
"env_variable": "WINETRICKS_RUN", | |||
"default_value": "vcrun2019 dotnet48", | |||
"default_value": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removed? The server needs vcruntimes.
Show me the error, that the server dont start with vcrun and dotnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This server have NO Autoupdate. Dont change the AUTO_UPDATE Variable to 1, else server is broken. | ||
|
||
### Server Ports | ||
|
||
Empyrion requires up to 2 ports | ||
Empyrion requires 1 port to run (the one required is marked with *), but if you want the server to be listed in the game browser or to make it accessible via telnet from a remote client, you must open the ports listed below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats wrong. You need all ports. all in all 4 ports. Telnet is not really important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the server with only one port and it seemed to work perfectly.
anyway there is no problem to change the readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will test the Egg later and fix it, when its needed.
Was on my ToDo list for the Weekend, because some asked me allready.
i see not really any change in the Egg. -nogralhics is the same as - batchmode and removing vcrun is also not needed.
Only change i agree is wine:stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was wrong, -nographics is not necessary, it was a leftover when I was trying to make it work.
So, i did some tests. The server runs fine with vcrun. I only updated to 2022, becsue it have all versions. I Used mono for dotnet. Telnet is needed for this egg, so do not disable it. I will update the egg on Saturday with more variables. |
But opening the port for telnet isn't actually needed. By the way, have you tried playing only with port 30000 open? Also, I tried again to create a new server without winetricks and it seems to work fine, it would seem that they are not actually needed, but at this point maybe I am doing something wrong. |
ty for your PR. I will fix my egg at weekend. there are more things to do and the only valid change is the wine stable image. I will take care about this too |
Description
I updated the egg since it was not working, removing winetricks since the server was not able to start with that and changing the wine docker image to the latest one instead of the staging one to improve stability.
I also updated the readme since it was showing wrong port numbers and marked the necessary ports.
Checklist for all submissions