Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API documentation #325

Merged
merged 11 commits into from
Nov 23, 2023
Merged

Update API documentation #325

merged 11 commits into from
Nov 23, 2023

Conversation

tdittr
Copy link
Contributor

@tdittr tdittr commented Nov 21, 2023

No description provided.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c856131) 68.77% compared to head (796e54f) 68.98%.
Report is 2 commits behind head on main.

Files Patch % Lines
statime-linux/src/clock/mod.rs 0.00% 4 Missing ⚠️
statime-linux/src/main.rs 0.00% 3 Missing ⚠️
statime/src/ptp_instance.rs 0.00% 2 Missing ⚠️
statime/src/port/mod.rs 66.66% 1 Missing ⚠️
statime/src/port/state/slave.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   68.77%   68.98%   +0.20%     
==========================================
  Files          49       49              
  Lines        5826     5855      +29     
==========================================
+ Hits         4007     4039      +32     
+ Misses       1819     1816       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@davidv1992 davidv1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not just add the docs messages, but also exposes the internal structure of the crate in how it is organized to the outside world. I am not sure this is a good idea in general, and in particular if we want to have that discussion, I strongly suggest we do it in a separate PR. Could you split that off from these changes?

@tdittr
Copy link
Contributor Author

tdittr commented Nov 23, 2023

I think this is ready to merge now.

API re-organization was resolved in an offline discussion.

@tdittr tdittr requested a review from davidv1992 November 23, 2023 11:27
@davidv1992 davidv1992 merged commit 1da068e into main Nov 23, 2023
4 checks passed
@davidv1992 davidv1992 deleted the api-docs branch November 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants