-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API documentation #325
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 68.77% 68.98% +0.20%
==========================================
Files 49 49
Lines 5826 5855 +29
==========================================
+ Hits 4007 4039 +32
+ Misses 1819 1816 -3 ☔ View full report in Codecov by Sentry. |
This makes the docs a bit easier to follow, as the user now is not confronted with all the structs, enums and traits at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not just add the docs messages, but also exposes the internal structure of the crate in how it is organized to the outside world. I am not sure this is a good idea in general, and in particular if we want to have that discussion, I strongly suggest we do it in a separate PR. Could you split that off from these changes?
I think this is ready to merge now. API re-organization was resolved in an offline discussion. |
No description provided.