Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging #606

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Fix packaging #606

merged 2 commits into from
Feb 7, 2025

Conversation

tdittr
Copy link
Contributor

@tdittr tdittr commented Feb 5, 2025

No description provided.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.26%. Comparing base (6610c64) to head (8528888).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   62.47%   62.26%   -0.22%     
==========================================
  Files          62       62              
  Lines        8294     8322      +28     
==========================================
  Hits         5182     5182              
- Misses       3112     3140      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdittr tdittr force-pushed the fix-packaging branch 2 times, most recently from ab5ffb6 to a925d8c Compare February 5, 2025 15:25
@tdittr tdittr changed the base branch from main to dev-0.2.3 February 6, 2025 11:08
@tdittr tdittr marked this pull request as ready for review February 6, 2025 11:19
@tdittr tdittr requested a review from davidv1992 February 6, 2025 11:19
Copy link
Member

@davidv1992 davidv1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the systemd unit files for the exporter

@tdittr tdittr changed the base branch from dev-0.2.3 to main February 6, 2025 14:47
@tdittr
Copy link
Contributor Author

tdittr commented Feb 6, 2025

Not sure if we should enable the metrics exporter service by default.

This was still missing after adding the metrics exporter binary.
@tdittr
Copy link
Contributor Author

tdittr commented Feb 6, 2025

Not sure if we should enable the metrics exporter service by default.

Done! It was already not enabled by default 😁

@davidv1992 davidv1992 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit b9b1269 Feb 7, 2025
4 checks passed
@davidv1992 davidv1992 deleted the fix-packaging branch February 7, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants