Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-rauc: allow to specify an offset to skip input bytes #241

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

ukleinek
Copy link
Contributor

This is useful for barebox images on (at least) i.MX8 to be written to eMMC. There the first 32K of the image must be skipped.

@ukleinek
Copy link
Contributor Author

Having the DCO check enabled for a project that doesn't formalize the meaning of a S-o-b line is ridiculous. I assume I can ignore that failing check.

@michaelolbrich
Copy link
Member

Having the DCO check enabled for a project that doesn't formalize the meaning of a S-o-b line is ridiculous. I assume I can ignore that failing check.

You're right, but we should formalize that instead. I've created #242 for that. Can you take a look please to see if it make sense like that?

image-rauc.c Outdated Show resolved Hide resolved
@ukleinek ukleinek force-pushed the rauc-offset branch 2 times, most recently from 9fedd8d to e722375 Compare March 22, 2024 16:47
Copy link
Member

@michaelolbrich michaelolbrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a newer rauc version than the one used in the CI. This is unrelated to your change. Just drop the those changes and ignore your local errors.

test/misc.test Outdated Show resolved Hide resolved
test/misc.test Outdated Show resolved Hide resolved
test/test.raucb.info.new Outdated Show resolved Hide resolved
test/test2.raucb.info Outdated Show resolved Hide resolved
test/test2.raucb.info.new Outdated Show resolved Hide resolved
@ukleinek ukleinek force-pushed the rauc-offset branch 2 times, most recently from f335bcd to cd1a612 Compare March 22, 2024 17:55
@ukleinek
Copy link
Contributor Author

You have a newer rauc version than the one used in the CI. This is unrelated to your change. Just drop the those changes and ignore your local errors.

Huh, these were not supposed to be pushed. My intention was to have these locally to be able to test before pushing and seeing the CI fail. Fixed now.

This is useful for barebox images on (at least) i.MX8 to be written to
eMMC. There the first 32K of the image must be skipped.

Signed-off-by: Uwe Kleine-König <[email protected]>
Copy link
Member

@michaelolbrich michaelolbrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks.

@michaelolbrich michaelolbrich merged commit 915ced7 into pengutronix:master Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants