Hdimage cleanup #253
Merged
Hdimage cleanup #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the whole thing separately and more explicitly: - check if an extended partition is needed first - insert the extended partition and mark all logical partitions Signed-off-by: Michael Olbrich <[email protected]>
With the extended partition handling split out, there is no need to loop twice here. Signed-off-by: Michael Olbrich <[email protected]>
Signed-off-by: Michael Olbrich <[email protected]>
Signed-off-by: Michael Olbrich <[email protected]>
The last partition may not be the one at the end of the image, so it could happen, that file_size is overwritten with a smaller value. It's usually not notiable because the value is only used for the initial image size. The file can grow larger when it is actually filled. Signed-off-by: Michael Olbrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and split
hdimage_setup()to make it easier to understand.