Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvements] Migrate to Django 5 #308

Merged
merged 6 commits into from
Sep 13, 2024
Merged

[Improvements] Migrate to Django 5 #308

merged 6 commits into from
Sep 13, 2024

Conversation

trangiabach
Copy link
Contributor

@trangiabach trangiabach commented Mar 24, 2024 •
edited
Loading

This PR:

  • Migrates django from 3.1.7 to 5.0.3
  • Migrates channels from <=3 to 3.0.5 (higher version will break django-rest-live used for the web socket)
  • Migrates Python to 3.11. Change base image to support this version

@benjmnxu benjmnxu requested a review from judtinzhang March 28, 2024 00:57
benjmnxu
benjmnxu reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@benjmnxu benjmnxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you just check why the pipfile.lock is conflicting. probably an issue with some new packages installed for calendar

@benjmnxu benjmnxu merged commit 1323ef4 into master Sep 13, 2024
5 checks passed
@benjmnxu benjmnxu deleted the django-migrate branch September 13, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjmnxu benjmnxu benjmnxu left review comments

@judtinzhang judtinzhang judtinzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trangiabach @judtinzhang @benjmnxu