Skip to content

Commit

Permalink
v2
Browse files Browse the repository at this point in the history
  • Loading branch information
penqee committed Apr 8, 2024
1 parent 6b06c68 commit e969752
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
6 changes: 2 additions & 4 deletions videoweb/.golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@ linters:
- gosimple
- govet
- ineffassign
- staticcheck
- unused
- errchkjson
- errname
- asciicheck
- bodyclose
- exhaustive
- nilerr
- nestif


linters-settings:
govet:
enable:
Expand Down
1 change: 1 addition & 0 deletions videoweb/cmd/chat/service/model.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ func newClient(conn *websocket.Conn, uid string) *Client {
func (c *Client) SendHistory(msgs []*model.Message) {
var err error
for _, item := range msgs {

buf := make([]byte, 0)

Check failure on line 59 in videoweb/cmd/chat/service/model.go

View workflow job for this annotation

GitHub Actions / lint

ineffectual assignment to buf (ineffassign)

if buf, err = json.Marshal(item); err == nil {
Expand Down
11 changes: 6 additions & 5 deletions videoweb/cmd/chat/service/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,20 @@ func MessageHandler() {

if broadcast.Type == e.SingleChat { //单聊
msgJSON, _ := json.Marshal(broadcast)

//存储到数据库

if !Clients[ClientsSingleMap[broadcast.FromUid]] { //对方有无上线
err := rabbitmq.PublishMsg(msgJSON, broadcast.Target)
if err != nil {
log.Println(err)
return
continue
}
log.Println("对方未上线")
err = msgDao.StoreSingleChatMsg(broadcast.FromUid, broadcast.Target, broadcast.Content, false)
if err != nil {
log.Println(err)
return
continue
}
continue
}
Expand All @@ -43,7 +44,7 @@ func MessageHandler() {
err := msgDao.StoreSingleChatMsg(broadcast.FromUid, broadcast.Target, broadcast.Content, true)
if err != nil {
log.Println(err)
return
continue
}
default:
close(ClientsSingleMap[broadcast.FromUid].send)
Expand All @@ -52,9 +53,9 @@ func MessageHandler() {
}

} else if broadcast.Type == e.GroupChat { //群聊

var err error
var members = make([]string, e.MaxStore)

Check failure on line 57 in videoweb/cmd/chat/service/run.go

View workflow job for this annotation

GitHub Actions / lint

ineffectual assignment to members (ineffassign)
members, err := cache.RedisClient.SMembers(context.Background(), broadcast.Target).Result()
members, err = cache.RedisClient.SMembers(context.Background(), broadcast.Target).Result()
if err != nil {
log.Println(err)
}
Expand Down
4 changes: 2 additions & 2 deletions videoweb/cmd/chat/service/ws.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ func (c *Client) read() {
break
}

msgToBroadcast := new(MsgFromBroadcast)
msgToBroadcast = &MsgFromBroadcast{
//msgToBroadcast := new(MsgFromBroadcast)
msgToBroadcast := &MsgFromBroadcast{
Type: msg.Type,
Content: msg.Content,
Target: c.Target,
Expand Down

0 comments on commit e969752

Please sign in to comment.