Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow string representation of converted yaml #369 #488

Merged
merged 11 commits into from
Jul 15, 2024
Merged

allow string representation of converted yaml #369 #488

merged 11 commits into from
Jul 15, 2024

Conversation

donaldcampbelljr
Copy link
Contributor

Fixes #369

@donaldcampbelljr
Copy link
Contributor Author

I've added pytest coverage for this change. Please review and merge @khoroshevskyi at your convenience.

@khoroshevskyi khoroshevskyi changed the base branch from dev to minor_fixes July 15, 2024 18:31
khoroshevskyi
khoroshevskyi approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@khoroshevskyi khoroshevskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@khoroshevskyi khoroshevskyi merged commit 24657d2 into minor_fixes Jul 15, 2024
1 check passed
@khoroshevskyi khoroshevskyi deleted the dev_369 branch July 15, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khoroshevskyi khoroshevskyi khoroshevskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donaldcampbelljr @khoroshevskyi