EVEREST-1836 PSMDB 1.19.0 #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod # go.sum
# Conflicts: # .github/workflows/ci.yml # go.mod # go.sum # internal/controller/providers/psmdb/applier.go
This was referenced Jan 27, 2025
Comment on lines
-57
to
+70
| // 1-node cluster, former 1-node cluster, a cluster with deprecated AllowUnsafeConfiguration | ||
| value := p.DB.Spec.Engine.Replicas == 1 || p.PerconaServerMongoDB.Spec.UnsafeConf || p.DB.Spec.AllowUnsafeConfiguration | ||
| p.PerconaServerMongoDB.Spec.UnsafeConf = value | ||
| p.PerconaServerMongoDB.Spec.UnsafeConf = false | ||
| useInsecureSize := p.DB.Spec.Engine.Replicas == 1 || p.DB.Spec.AllowUnsafeConfiguration | ||
| p.PerconaServerMongoDB.Spec.Unsafe = psmdbv1.UnsafeFlags{ | ||
| TLS: p.DB.Spec.AllowUnsafeConfiguration, | ||
| MongosSize: useInsecureSize, | ||
| ReplsetSize: useInsecureSize, | ||
| TerminationGracePeriod: p.DB.Spec.AllowUnsafeConfiguration, | ||
| BackupIfUnhealthy: p.DB.Spec.AllowUnsafeConfiguration, | ||
| } | ||
| if p.DB.Spec.AllowUnsafeConfiguration { | ||
| p.PerconaServerMongoDB.Spec.TLS = &psmdbv1.TLSSpec{ | ||
| Mode: psmdbv1.TLSModeDisabled, | ||
| } | ||
| } |
There was a problem hiding this comment.
Using p.DB.Spec.AllowUnsafeConfiguration for backward compatibility with the already existing clusters on the Everest side. However on the psmdb side we don't use p.PerconaServerMongoDB.Spec.UnsafeConf anymore but use more specific psmdbv1.UnsafeFlags flags.
Here is how psmdb handles psmdbv1.UnsafeFlags, that's why to make the old clusters work correctly we also need to set .PerconaServerMongoDB.Spec.TLS for them.
recharte
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
EVEREST-1836
Add support for PSMDB 1.19.0
Related pull requests
CHECKLIST
Helm chart
Jira
Tests