Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PS-9504: Replace MY_NODISCARD with [[nodiscard]] #5488

Open
wants to merge 1 commit into
base: 8.4
Choose a base branch
from
Open

PS-9504: Replace MY_NODISCARD with [[nodiscard]] #5488

wants to merge 1 commit into from

Conversation

inikep
Copy link
Collaborator

@inikep inikep commented Nov 18, 2024

We require at least gcc 7.1 or clang 5 for compilation which both support [[nodiscard]].
MY_NODISCARD is no longer needed.

percona-ysorokin
percona-ysorokin approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inikep inikep changed the base branch from 8.4 to 8.0 November 18, 2024 10:08
@inikep inikep changed the base branch from 8.0 to 8.4 November 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@percona-ysorokin percona-ysorokin percona-ysorokin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inikep @percona-ysorokin