SE-100: don't dump when instance is not found #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svetasmirnova
approved these changes
Oct 4, 2024
artemgavrilov
approved these changes
Jan 31, 2025
| @@ -44,17 +45,18 @@ func TestExportImport(t *testing.T) { | |||
| if err := g.Wait(); err != nil { | |||
| t.Fatal(err) | |||
| } | |||
| time.Sleep(30 * time.Second) | |||
There was a problem hiding this comment.
It would be great to have comment there what we are waiting here.
Comment on lines
+59
to
+62
| if strings.Contains(stderr, "Failed to create a dump. No data was found") { | ||
| // If pmm-dump returns this error, it also means that the dashboard selector parsing was successful | ||
| return | ||
| } |
There was a problem hiding this comment.
It looks like relying on exit code may be a better option rather than error text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/SE-100
In this PR,
pmm-dumpwill fail during export when it can't find any data, and it will display the messageFailed to create a dump. No data was found.If the
--instanceflag was provided, it will issue a warning before failing, with the messageIt seems that data about instances specified in the `--instance` option does not exist in the PMM server.