pmapi: fix error messages

add linting rule to not accidentally use [window.]name

See microsoft/TypeScript#14306 for details

.eslintrc.json

@@ -7,6 +7,18 @@
     },
     "rules": {
         "@typescript-eslint/no-floating-promises": "error",
+        "no-restricted-globals": [
+            "error",
+            "name",
+            "close",
+            "history",
+            "length",
+            "open",
+            "parent",
+            "scroll",
+            "stop",
+            "event"
+        ],
         "no-console": [
             "error",
             {}

.gitignore

@@ -1,4 +1,6 @@
 node_modules/
+# Golang vendor dir
+vendor/
 vendor_jsonnet/
 
 dist/

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 3.0.1 (unreleased)
 
 ### Enhancements / Bug Fixes
+- **vector, bpftrace**: fix error messages regarding missing metrics
 - **test**: fix PCP Redis datasource test on 32bit architectures
 
 

src/common/services/pmapi/PmApiService.ts

@@ -107,7 +107,7 @@ export class PmApiService {
             return response.data;
         } catch (error) {
             if (has(error, 'data.message') && error.data.message.includes('metric has null indom')) {
-                throw new NoIndomError(name);
+                throw new NoIndomError(params.name);
             } else {
                 throw error;
             }
@@ -140,12 +140,12 @@ export class PmApiService {
             return response.data;
         } catch (error) {
             if (has(error, 'data.message') && error.data.message.includes('failed to lookup metric')) {
-                throw new MetricNotFoundError(name);
+                throw new MetricNotFoundError(params.name);
             } else if (
                 has(error, 'data.message') &&
                 error.data.message.includes('No permission to perform requested operation')
             ) {
-                throw new PermissionError(name);
+                throw new PermissionError(params.name);
             } else if (has(error, 'data.message') && error.data.message.includes('Bad input')) {
                 return { success: false };
             } else {