build: add golangci-lint and run lint on CI again (#56)

.travis.yml

@@ -1,12 +1,12 @@
 language: go
 go:
-  - 1.9.x
   - 1.10.x
   - 1.11.x
   - 1.12.x
   - tip
 env:
   global:
+    - GO111MODULE=on
     # coveralls token
     - secure: Tt++Fdp5IqwJyYuK5EFA29BHGInHxVylFQMRtvpNt2qMZA89Z1N4BUDswqVu23TaMwoFM0a1/E3tAuC0Ffqm19oS8jnFyonuFlXduwG8iVb8znWzP67Jtj9l5xDzra/NhdhE25OxUD3b203rOMChpRx77i+eBITlaYsOMUTq/K77at+NW58qL3W7h6vu4WFBG0T0RbEVjp+IxSJiAUJI9jSYYldo7EpeDL/BqMJeMVe1D0UfVa/DU0GNdDKYibmF+Mag/v34ttlfdYarLEicwQpcQb52NfrRg06iPmiiqRsN/glU2clzkJPLZUmx3UgMPK8nKg4Iu8LXKMCm46UhnnsWcXjnquioLa8vPCv2hoModCcwjGLqC4BHnnh4QqNkMnL3UpLWQcT5zrqvsEIcy1TpwKwOEcIRo1ZqEmgl2kkz5hBN6hjFKR44Uti2ayw831X8FRxyGsq7O6b8R7M4w5gdt12Hj2V04Qnr718ZBhsrbNn+GPPv3p9Pspal9CXvuWTnIRbPCw0DOdajLIX9JMUB86ElPqLGxHBsrc6Ev2rsFPlJZqyur9KBU/KJfmlhrV8veksorugMk6nxshzS0P8eAdbmC+xTo999LQPNZqsNVfbKI97UKkfy7jZxHLDriTBD9qHtJSt+J2wkcS6iGrNe5bEpksZAmxJlSwSqIuY=
 before_install:
@@ -18,6 +18,7 @@ before_script:
   - make
 script:
   - make race
+  - make lint
   - "$HOME/gopath/bin/goveralls -v -service=travis-ci -package=."
 notifications:
   email:

Makefile

@@ -14,11 +14,11 @@ gen:
 
 deps:
 	go get -u golang.org/x/tools/cmd/stringer
-	go get -u gopkg.in/alecthomas/gometalinter.v1
-	gometalinter.v1 --install
+	curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s v1.15.0
+	bin/golangci-lint --version
 
 lint:
-	gometalinter.v1 ./... --vendor --deadline=1h --dupl-threshold=100 --disable=interfacer --disable=gas
+	bin/golangci-lint run
 
 test:
 	go test -v ./...

appveyor.yml

@@ -5,8 +5,6 @@ clone_folder: c:\gopath\src\github.com\performancecopilot\speed
 environment:
   GOPATH: c:\gopath
   matrix:
-    - environment:
-      GOVERSION: 1.9.7
     - environment:
       GOVERSION: 1.10.8
     - environment:

client.go

@@ -309,8 +309,6 @@ func (c *PCPClient) writeHeaderBlock(genc chan int64, g2offc chan int) {
 	// or deadlock
 	genc <- gen
 	g2offc <- g2off
-
-	return
 }
 
 func (c *PCPClient) writeTocBlock() {

metrics.go

@@ -35,11 +35,11 @@ func (m MetricType) isCompatibleInt(val int) bool {
 	case Int32Type:
 		return v >= math.MinInt32 && v <= math.MaxInt32
 	case Int64Type:
-		return v >= math.MinInt64 && v <= math.MaxInt64
+		return true
 	case Uint32Type:
 		return v >= 0 && v <= math.MaxUint32
 	case Uint64Type:
-		return v >= 0 && uint64(v) <= math.MaxUint64
+		return v >= 0
 	}
 	return false
 }

mmvdump/mmvdump_test.go

@@ -80,7 +80,7 @@ func TestInputs(t *testing.T) {
 
 		actual := b.Bytes()
 
-		if bytes.Compare(expected, actual) != 0 {
+		if !bytes.Equal(expected, actual) {
 			t.Fatalf(`
 Failed for input %s,
 expected

speed_test.go

@@ -20,6 +20,7 @@ func BenchmarkGetHash(b *testing.B) {
 	}
 }
 
+//lint:ignore U1000 keeping for now
 type testWriter struct {
 	message string
 	t       testing.TB