fix(beamr): prevent race condition in debug logging from C #108
+201
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A race condition in the C debug logging caused occasional segfaults during massive import tests. The issue arose from concurrent execution of hb_driver.c functions and wasm_handle_import. For example, drv_unlock would release a lock, while wasm_handle_import—running in parallel—could destroy it before drv_unlock completed its debug logging, leading to undefined behavior. This fix ensures that the names of cond and mutex are copied before releasing the lock, allowing debug prints to use the copied values safely.
…er_results fix(hb_beamr): clean up memory allocated for storing import results
fix: fix memory leaks in hb_wasm wasm_handle_import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race condition in the C debug logging caused occasional segfaults during massive import tests. The issue arose from
concurrent execution of hb_driver.c functions and wasm_handle_import.
For example, drv_unlock would release a lock, while wasm_handle_import—running in parallel—could destroy it before drv_unlock completed its debug logging, leading to undefined behavior.
This fix ensures that the names of cond and mutex are copied before releasing the lock, allowing debug prints
to use the copied values safely.