Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the v3 specs #62

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Follow the v3 specs #62

merged 2 commits into from
Dec 8, 2023

Conversation

dannyhajj
Copy link
Member

@dannyhajj dannyhajj commented Dec 8, 2023

Type of change

  • New feature
  • Bug fix
  • Security patch
  • Documentation update

Description

A bit of rewriting of the package, mainly.

  • Most of the tests were not running at all, as the functions were breaking out of the test method when the ssn was invalid, which is the case starting from the first time in the list of ssns.
  • Made the package align more with the v3 versions and implemented the get_date method from v3.1.
  • It is still missing the Interim-Number functionality, but I have to increase the minor version as it has some breaking changes of undocumented functionality, which should not be used outside of the library (next point).
  • I prepended several methods with an underscore (_) that are not part of the meta documentation. These are somewhat annoying as IDE will show them in their auto-completion functionality. Having the underscore indicates that a method is only intended for internal use, as defined by PEP8.

Missing functionality

  • More functionality needs to be tested, such as the is_coordination_number() method and the new get_age() method. But the PR was getting bigger and bigger and the tests were not working I decided to stop there and those can be done in a different PR.
  • Parsing Interim-Number

Related issue

N/A

Motivation

Tests were not working.

Checklist

  • I have read the CONTRIBUTING document.
  • I have read and accepted the Code of conduct
  • Tests pass.
  • Style lints passes.
  • Documentation of new public methods exists.
  • New tests added which covers the added code.
  • Documentation is updated.
  • This PR includes breaking changes (but only undocumented functionality).

@frozzare
Copy link
Member

frozzare commented Dec 8, 2023

Looks good from my basic python knowledge! Awesome work 😄

@frozzare frozzare merged commit dfc45c7 into personnummer:master Dec 8, 2023
7 checks passed
@dannyhajj dannyhajj deleted the v3-specs branch December 11, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants