Merge pull request #368 from petalframework/button_group_warning

Address Button Group warnings

lib/petal_components/button_group.ex

@@ -61,17 +61,20 @@ defmodule PetalComponents.ButtonGroup do
     doc: "class to customize the button border styles"
 
   # We mark validate_attrs false so passing phx-click etc. does not emit warnings
-  slot :button, required: true, validate_attrs: false do
-    attr :class, :string, doc: "classes in addition to those already configured"
-    attr :label, :string, doc: "a button label, rendered if you don't provide an inner block"
+  slot :button, required: true, validate_attrs: false
 
-    attr :kind, :string,
-      values: ["button", "link"],
-      doc: "determines whether we render a button or a <.link />"
+  # :button slot attributes. Thought they're commented out, they're still relevant. It's just
+  # that they can't be used in a do block with `validate_attrs: false`
+  #
+  # attr :class, :string, doc: "classes in addition to those already configured"
+  # attr :label, :string, doc: "a button label, rendered if you don't provide an inner block"
 
-    attr :disabled, :boolean,
-      doc: "disables the button - will turn an <a> into a <button> (<a> tags can't be disabled)"
-  end
+  # attr :kind, :string,
+  #   values: ["button", "link"],
+  #   doc: "determines whether we render a button or a <.link />"
+
+  # attr :disabled, :boolean,
+  #   doc: "disables the button - will turn an <a> into a <button> (<a> tags can't be disabled)"
 
   def button_group(assigns) do
     ~H"""

lib/petal_components/dropdown.ex

@@ -73,7 +73,7 @@ defmodule PetalComponents.Dropdown do
           <% end %>
 
           <%= if !@label && @trigger_element == [] do %>
-            <.icon name="hero-ellipsis-vertical-solid" class="h-5 w-5pc-dropdown__ellipsis" />
+            <.icon name="hero-ellipsis-vertical-solid" class="h-5 w-5 pc-dropdown__ellipsis" />
           <% end %>
         </button>
       </div>