New Release 3.1.1

[petretiandrea]

No description provided.

[bramstroker]

I think you should just return here {ColorMode.BRIGHTNESS} and not append to the set, as the documentation states it should be the only possible color mode.
Same applies to ONOFF.

So for example supported modes set to color_temp, brightness should never be possible.

[petretiandrea]

The code follows the HA algorithm describe here https://developers.home-assistant.io/docs/core/entity/light/#color-modes. Don't you agree?

[bramstroker]

That's also the resource where my screenshot is from.
So this is not correct, as in the current implementation you have now there could potentially be scenarios where brightness could be mixed with other color modes in the supported_color_modes, but it has to be the only one.

See also the explanation how to correctly determine the color modes:

[petretiandrea]

The if has the and not device.is_color_temperature and not device.is_color so cannot be mixed with other color modes. No?

[bramstroker]

Yes, I see you are correct about that.
However I see potential issue with the last condition:

if not device.is_color_temperature and not device.is_color:
        color_modes.append(ColorMode.ONOFF)

This does not check for brightness.
So you'll end up with brightness, onoff as supported color modes, which is not valid.

Maybe rewrite to:

if not color_modes:
     color_modes.append(ColorMode.ONOFF)

Similarly as HA suggests in their approach.

[petretiandrea]

Ok, now It's clear and I agree with you

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
custom_components/tapo
__init__.py	67	3	96%	63, 73–74
config_flow.py	177	63	64%	79, 138–171, 180, 185–194, 214, 222, 237–245, 274, 304, 309–315, 320–323, 326–330, 336, 342–347
coordinators.py	55	2	96%	90, 92
diagnostics.py	13	13	0%	1–22
discovery.py	20	8	60%	17–22, 31–35
errors.py	7	1	86%	6
hass_tapo.py	42	1	98%	67
helpers.py	38	8	79%	20, 28, 40, 66, 70–74
light.py	131	10	92%	64, 67–72, 89–90, 211, 213
migrations.py	18	9	50%	14–30
setup_helpers.py	24	2	92%	37–38
update.py	79	27	66%	50, 54, 58–64, 84–87, 93–103, 108, 112–113, 119–120, 124–125
custom_components/tapo/hub
binary_sensor.py	66	17	74%	34–39, 48, 52, 56, 67, 71, 75, 84, 88, 92, 103–105, 109, 113, 117
climate.py	65	4	94%	26–28, 73
hass_tapo_hub.py	51	8	84%	65–69, 91, 113, 119
number.py	62	4	94%	29–31, 85
sensor.py	123	34	72%	43–53, 64–65, 69, 73, 77, 81, 85–87, 100–102, 106, 110, 114, 118–123, 127, 169–171, 175, 179, 183, 187, 191
siren.py	48	1	98%	100
switch.py	75	11	85%	21–27, 43, 47, 50–51, 54–55
custom_components/tapo/sensors
__init__.py	54	7	87%	27, 42, 72, 88–89, 104, 119
tapo_sensor_source.py	8	2	75%	8, 11
TOTAL	1454	235	84%

Tests	Skipped	Failures	Errors	Time
67	0 💤	0 ❌	0 🔥	4.468s ⏱️

[github-actions]

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

• 3.1.0
• GitHub release

Your semantic-release bot 📦🚀