New way to register dynamic constituents #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this @gold2718 We intend to redo a lot of the dynamic constituent work by implementing a new pre-init or register phase (pending further discussion) so I might take this and add it to that if that works? We planned to discuss this with you further on Monday - something to look forward to! |
|
Feel free to do whatever you want. I sent this because I think there is an indexing bug in the current PR so I thought that removing all the indexing and copying would be easier. Your call. |
|
Closing this, but will likely work it into the new iteration coming soon-ish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an idea of how to register dynamic constituents without having to copy into a new array. I think I ran all the tests on it.