Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "is_scheme_constituent" interface #6

Merged
merged 7 commits into from
Aug 29, 2023
Merged

New "is_scheme_constituent" interface #6

merged 7 commits into from
Aug 29, 2023

Conversation

peverwhee
Copy link
Owner

Adds new "_ccpp_is_scheme_constituent" interface to the cap. Interface returns true iff the provided variable name is found in _model_const_stdnames

Testing:

  • Added new tests to advection test
  • Ran FKESSLER with null dycore

nusbaume
nusbaume requested changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mostly just some optional python clean-up and some changes to the testing code.

scripts/constituents.py Outdated Show resolved Hide resolved
scripts/host_cap.py Outdated Show resolved Hide resolved
scripts/host_cap.py Outdated Show resolved Hide resolved
test/advection_test/test_host.F90 Outdated Show resolved Hide resolved
test/advection_test/test_host.F90 Outdated Show resolved Hide resolved
test/advection_test/test_host.F90 Outdated Show resolved Hide resolved
test/advection_test/test_host.F90 Outdated Show resolved Hide resolved
test/advection_test/test_host.F90 Show resolved Hide resolved
test/advection_test/test_host.F90 Outdated Show resolved Hide resolved
test/advection_test/test_host.F90 Show resolved Hide resolved
nusbaume
nusbaume approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!

@peverwhee peverwhee merged commit 90339ae into add_const_interface Aug 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nusbaume nusbaume nusbaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peverwhee @nusbaume