Add new water species constituent property #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaxmonsky
requested changes
Oct 9, 2023
mwaxmonsky
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new water species constituent property.
This new property is a logical that flags whether a constituent is a type (or "species") of water. This
is needed at least for geopotential because it explicitly needs all thermodynamically-active water species
(which currently requires both a "thermo active" and a "water species" property). I could imagine other
schemes might also need water species information in the future.
User interface changes?: Yes
There are now new
is_water_speciesandset_water_speciesmethods a user can access to control the water_species property for a given constituent.Testing:
unit tests: Passed, including newly added
water_speciesproperty testsmanual testing: Used the new property in both CAM and CAM-SIMA (via
geoptential_temp) and everything worked as expected.