Adjust the log level to V(4) for insignificant reconciliation logs #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the log level of certain reconciliation-related logs to V(4). These logs are emitted even when the plugin does not cause any state changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need it:
Currently, the plugin emits several reconciliation-related logs at the V(2) level.
These logs are emitted every time reconciliation occurs, even when the plugin does not cause any state changes.
This results in an excessive number of log messages in our internal clusters.
According to the kubernetes logging guidelines, V(2) is intended for steady state information and important log messages.
For logs that do not relate to state changes, V(4) is more appropriate.
What this PR does:
This change will improve log readability.