Tidy operator depgraph edges #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ana Hobden <[email protected]>
Hoverbear
commented
Jan 25, 2022
| // NB: no break here. We need to be dependent on all externs that are operators | ||
| for (extern_item, &extern_index) in externs { | ||
| let fn_matches = |fn_name| item.module_path == extern_item.module_path && extern_item.name == fn_name; | ||
| let cmp_fn_matches = fn_matches(item.cmp_fn_name()); |
There was a problem hiding this comment.
This is pretty brittle and I'd prefer to extend this to be customizable in the future.
Hoverbear
commented
Jan 25, 2022
| @@ -12,6 +12,32 @@ pub struct PostgresOrdEntity { | |||
| pub id: core::any::TypeId, | |||
| } | |||
|
|
|||
| impl PostgresOrdEntity { | |||
| pub(crate) fn cmp_fn_name(&self) -> String { | |||
There was a problem hiding this comment.
These should probably be configurable.
|
Given https://github.com/zombodb/pgx/tree/master/pgx-examples/operators#automatically-deriving-operators-and-families I'm not going to work about making the names customizable for now. |
Signed-off-by: Ana Hobden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repairs #334 .