FromDatum overhaul #521
Closed
FromDatum overhaul #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constant was set to false in all every `FromDatum` implementation, and simply isn't necessary. Further changes to `FromDatum` are going to change how this idea worked in the first place.
This argument was never actually used, only passed around. And in many cases it was set to `pg_sys::InvalidOid` anyways.
```rust
} else if datum == 0 {
panic!("array was flagged not null but datum is zero");
}
```
As the function is already unsafe, there's no need for us to have a check for a case that is likely never going to happen. Postgres may send us a null datum, but as long as we check `is_null` first, we're okay.
This function ensures the desired Rust type is compatible with the backing Postgres type of the Datum being converted. If they're not compatible, an `Err` is returned rather than either panicking or leading to undefined behavior. It's not actually used anywhere yet.
|
closing this as all its changes are now part of #532... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls the
FromDatumtrait by making some backwards incompatible API changes.Primarily, the changes are:
const NEEDS_TYPIDconst field. All usages of it werefalsetypid: Oidargument from the::from_datum()function. This was never used in any meaningful way::try_from_datum(datum, is_null, type_oid) -> TryFromDatumResult<Option<Self>, TryFromDatumError)function that will return an Err if the providedtype_oidisn't compatible with the desired Rust typeIntoDatum::is_compatible_with(type_oid)function to help facilitate the aboveGoing forward, these changes will be necessary to help implement #502, #499, and to also cleanup our Spi interface.
Once merged, this will definitely require a semver minor version bump.