Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub task handling #12

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Sub task handling #12

wants to merge 4 commits into from

Conversation

PavelD
Copy link

@PavelD PavelD commented Apr 23, 2024

POC of sub task handling. Result of #11 .

On my test environment I'm not able to see labels. The background color is not propagated even if the color defaults to black :-( So I'm not sure if it's just my issue or it's some bug in display.

I can see labels only if I select them.

Ready for comments and advises as I'm not JavaScript or TypeScript developer.

@pgorod
Copy link
Owner

pgorod commented Apr 24, 2024

The labels and label colors are pulled directly from todoist, I'm guessing that if you're adding labels, without adding colors, that will have problems displaying.

(I'm just quickly looking at this on my mobile, haven't had a chance to test it)

But I wonder what would be the best way of displaying subtasks. Maybe we shouldn't be mixing that up with labels, which are a different concept. Maybe an indent would work? Or a smaller font?

I'm also curious as to how this works with sorting options, I don think it's easy to get the subtasks to always show under their respective tasks...

Thanks for your work, I'm looking forward to evolving this into a great new feature.

@PavelD
Copy link
Author

PavelD commented Apr 24, 2024

Hi,
I wrote in the 1st line it's POC or in other words MVP :-)

I just want to have some link between task and the subtask. I was considering to add prefix to the content filed (actually it looks like title of the task). But it brings new problems with the update of the subtask.

Label seems to me minimal change and sorting? Still better than before when subtasks were displayed together with common tasks.

@pgorod
Copy link
Owner

pgorod commented Apr 26, 2024

Can you post some screenshots of how it looks?

I'm currently reinstalling my OS and don't have a dev environmet set up

@PavelD
Copy link
Author

PavelD commented Apr 26, 2024

Next week. I'm not close to my HA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants