Skip to content

Commit

Permalink
Removed contributing document. Created quote and quosure section. Cre…
Browse files Browse the repository at this point in the history
…ated dear dev section
  • Loading branch information
bms63 committed Aug 9, 2022
1 parent ae3574e commit aa99b1e
Show file tree
Hide file tree
Showing 14 changed files with 104 additions and 88 deletions.
6 changes: 5 additions & 1 deletion R/quo.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
#'
#' @author Thomas Neitmann
#'
#' @keywords dev_utility
#' @keywords quo
#' @family quo
#'
#' @rdname dev_util_quo_c
#'
Expand All @@ -30,6 +31,9 @@ quo_c <- function(...) {
#'
#' @author Thomas Neitmann, Ondrej Slama
#'
#' @keywords quo
#' @family quo
#'
#' @noRd
#'
#' @examples
Expand Down
12 changes: 8 additions & 4 deletions R/quote.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
#'
#' @author Thomas Neitmann
#'
#' @keywords dev_utility
#' @keywords quo
#' @family quo
#'
#' @rdname dev_util_enumerate
#'
Expand Down Expand Up @@ -36,7 +37,8 @@ enumerate <- function(x, quote_fun = backquote, conjunction = "and") {
#'
#' @author Thomas Neitmann
#'
#' @keywords dev_utility
#' @keywords quo
#' @family quo
#'
#' @rdname dev_util_backquote
#'
Expand All @@ -52,7 +54,8 @@ backquote <- function(x) {
#'
#' @author Thomas Neitmann
#'
#' @keywords dev_utility
#' @keywords quo
#' @family quo
#'
#' @rdname dev_util_squote
#'
Expand All @@ -74,7 +77,8 @@ squote <- function(x) {
#'
#' @author Stefan Bundfuss
#'
#' @keywords dev_utility
#' @keywords quo
#' @family quo
#'
#' @examples
#' admiral:::dquote("foo")
Expand Down
9 changes: 4 additions & 5 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,12 @@ ADaM in R Asset Library Development Utilities

## Purpose

Tools for developing functions and maintaining a healthy codebase within the family of admiral R packages. `{admiraldev}` is intended to be used when developing `{admiral}` or `{admiral}` extension packages. Use of this package as a standalone package is not recommended.
Tools for developing functions and maintaining a healthy code base within the family of admiral R packages. `{admiraldev}` is intended to be used when developing `{admiral}` or `{admiral}` extension packages. Use of this package as a standalone package is currently not recommended.

## Installation

The package is available from CRAN and can be installed by running install.packages("admiraldev").

To install the latest development version of the package directly from GitHub use the following code:

```{r, eval = FALSE}
Expand All @@ -53,14 +55,11 @@ if (!requireNamespace("remotes", quietly = TRUE)) {
}
remotes::install_github("pharmaverse/admiraldev", ref = "devel")
remotes::install_github("pharmaverse/admiral.test", ref = "devel")
remotes::install_github("pharmaverse/admiral", ref = "devel")
```

## Release Schedule

`{admiraldev}` is to be release one week before the release of `{admiral}`. You can find the release schedule for `{admiral}` packages here(TBL)
`{admiraldev}` is to be release one week before the release of `{admiral}`. You can find the release schedule for `{admiral}` packages [here](https://github.com/pharmaverse/admiral/tree/devel#release-schedule)



Expand Down
16 changes: 9 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@ ADaM in R Asset Library Development Utilities

## Purpose

Tools for developing functions and maintaining a healthy codebase within
the family of admiral R packages. `{admiraldev}` is intended to be used
when developing `{admiral}` or `{admiral}` extension packages. Use of
this package as a standalone package is not recommended.
Tools for developing functions and maintaining a healthy code base
within the family of admiral R packages. `{admiraldev}` is intended to
be used when developing `{admiral}` or `{admiral}` extension packages.
Use of this package as a standalone package is currently not
recommended.

## Installation

The package is available from CRAN and can be installed by running
install.packages(“admiraldev”).

To install the latest development version of the package directly from
GitHub use the following code:

Expand All @@ -24,11 +28,9 @@ GitHub use the following code:
}

remotes::install_github("pharmaverse/admiraldev", ref = "devel")
remotes::install_github("pharmaverse/admiral.test", ref = "devel")
remotes::install_github("pharmaverse/admiral", ref = "devel")

## Release Schedule

`{admiraldev}` is to be release one week before the release of
`{admiral}`. You can find the release schedule for `{admiral}` packages
here(TBL)
[here](https://github.com/pharmaverse/admiral/tree/devel#release-schedule)
13 changes: 8 additions & 5 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ news:

reference:
- title: Assertion Functions
desc: Checks inputs for functions and provide error and messaging around those checks
desc: Checks the inputs for user-faceing functions and provides error, warnings and other messaging around expectation of inputs.
contents:
- has_keyword('assertion')

Expand Down Expand Up @@ -46,8 +46,13 @@ reference:
contents:
- has_keyword('test_helper')

- title: Quosure and Quoting Helper Functions
desc: Helping your quoting and quosure needs
contents:
- has_keyword('quo')

- title: Developer Utility Functions
desc: Utilities to help with organization and documenation
desc: General Utilities
contents:
- has_keyword('dev_utility')

Expand All @@ -60,12 +65,10 @@ navbar:
text: Developer Guides
menu:
- text: Overview
- text: Contribution to {admiral}
href: articles/contribution_model.html
- text: Development Process
href: articles/development_process.html
- text: -------
- text: "All things development"
- text: "{admiral} development processes"
- text: Programming Strategy
href: articles/programming_strategy.html
- text: Guidance for git and GitHub Usage
Expand Down
10 changes: 9 additions & 1 deletion man/dev_util_backquote.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion man/dev_util_enumerate.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion man/dev_util_quo_c.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion man/dev_util_squote.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion man/dquote.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/roxygen/meta.R
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ list(
is = "Identifies type of Object with return of TRUE/FALSE: ",
assertion = "Checks for valid input and returns warning or errors messages: ",
what = "Identifies type of object and returns type: ",
quo = "Helps for working with Quosures: ",
quo = "Helpers for working with Quosures and Quoting: ",
get = "Brings something to you!?!: ",
test_helper = "Helps with Testing: ",
dev_utility = "Developer Utility Functions: ",
Expand Down
Binary file removed vignettes/admiral_contribution_model.png
Binary file not shown.
27 changes: 24 additions & 3 deletions vignettes/admiraldev.Rmd
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
title: "Contribution to {admiral} and {admiraldev}"
title: "Get Started"
output:
rmarkdown::html_vignette

vignette: >
%\VignetteIndexEntry{Contribution to {admiral} and {admiraldev}}
%\VignetteIndexEntry{Get Started}
%\VignetteEngine{knitr::rmarkdown}
---

Expand All @@ -16,4 +16,25 @@ knitr::opts_chunk$set(
```


Some stuff here...
# Dear Developers

`{admiraldev}` is intended for you, the developer, to help make developing within the admiral family easier and consistently robust and maybe even fun!

Tools are loosely defined as follows:

* Utility Functions used in `{admiral}` and `{admiral}` extension functions for doing custom checks and providing custom messages, warnings and errors. These cusotm messages, warnings and errors are succint, but helpful messaging around what a function expects as inputs. The inputs to admiral functions are many, but generally fit into three categories: datasets, variables and arguments. Most of the functions start with `assert_`, `is_` or `get_`.

* Addins and utility functions that help with documentation, testing and checking on health of the code base in all admiral packages.

* Vignettes on working on `{admiral}` functions, developing unit testing, releases process, vignette writing and other documenation. These vignettes are intended for use across admiral packages.

# Adding new tools

* Just like in `{admiral}`, we follow the same procedures of adding issues, developing those issues in branches and doing a Pull Request.

* Experimental tools are highly encouraged to help reduce repetitive patterns and automating the boring stuff.





57 changes: 0 additions & 57 deletions vignettes/contribution_model.Rmd

This file was deleted.

0 comments on commit aa99b1e

Please sign in to comment.