Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flyTo bug #34

Closed
wants to merge 38 commits into from
Closed

fix flyTo bug #34

wants to merge 38 commits into from

Conversation

JoshMLeslie
Copy link
Collaborator

closes #32

I don't like the idea of the side bar closing as a side-effect to begin with, which is what was happening, and in doing so, triggering the "easeTo" animation / canceling out "flyTo"

@JoshMLeslie JoshMLeslie linked an issue Jan 22, 2025 that may be closed by this pull request
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for pcwnetworkmap ready!

Name Link
🔨 Latest commit b28285d
🔍 Latest deploy log https://app.netlify.com/sites/pcwnetworkmap/deploys/6797e27c9836620008d3aca9
😎 Deploy Preview https://deploy-preview-34--pcwnetworkmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

remove redundant mapbox cdn ref
@JoshMLeslie JoshMLeslie changed the title remove background listener that "easing" sidebar / map fix flyTo bug Jan 22, 2025
@fmvaldezg
Copy link
Contributor

fmvaldezg commented Jan 22, 2025

The reason for the sidebar closing was to improve the visualization on the small frame that is on the website. We might think on a different way to solve this. image

@JoshMLeslie
Copy link
Collaborator Author

ugh rebasing screwed this up. gonna delete the branch since there was very little changed and just make a new one

@JoshMLeslie JoshMLeslie deleted the 32-fix-flyto branch January 27, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Navigate to" buttons are not flying
3 participants