-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Renderable interfaces to module #619
Extract Renderable interfaces to module #619
Conversation
This is a great start! I’d quite like to separate the SGML stuff from the renderable stuff where SGML is a specific implementation of renderable that buffers SGML tags, but other objects could implement the renderable interface just by implementing Then the |
These names might not be quite right, but here's the main parts I think we should have:
It might even make sense to have a layer between 1 and 2 that provides the buffer, context, capture, etc. without any of the SGML element macros. |
For 3 and 4 I thought of 2 optiions:
For both of those might be pros and cons. I think I like the second one best, but I'm absolutely flexible about this |
@joeldrapper also, I'm working on a Linux machine and don't have a Mac. Could you help me solve failing Mac specs? |
b5a4224
to
5d6b6dd
Compare
Hey @iachettifederico, sorry this ended up going stale. I’m going to open a new PR for this. |
This PR is a Work in progress, since it's missing some tests and documentation.
SGML
toRenderable
moduleHTML
toHtmlRenderable
moduleSVG
toSvgRenderable
moduleAll the tests that were on the repository are passing