Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some features for EJBindingAdBanner #351

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

finscn
Copy link
Contributor

@finscn finscn commented Mar 7, 2014

adBanner.alwaysPortrait : if true force the iAd to be Portrait mode, or iAd to be auto mode
adBanner.isAtRight: if use "Portrait iAd" in Landscape device, let ad align to right

adBanner.x : get/set Position X
adBanner.y : get/set Position Y

adBanner.width (readOnly) return the adBanner's real size ( banner.frame's size)
adBanner.height (readOnly) return the adBanner's real size ( banner.frame's size)

@finscn
Copy link
Contributor Author

finscn commented Mar 7, 2014

this pull request is for #350

change  false to NO  for Ejecta's style
@finscn
Copy link
Contributor Author

finscn commented Mar 7, 2014

in iOS 6 later, Apple supplies a new Ad type:
ADAdTypeMediumRectangle ( iPad only)

I integrated it in ejecta like this:

// type="rect", "rectangle" "MediumRectangle" will use ADAdTypeMediumRectangle.
// other value will use ADAdTypeBanner
new Ejecta.AdBanner( type )

finscn added 4 commits March 7, 2014 18:35
supports  "ADAdTypeMediumRectangle"
supports  "ADAdTypeMediumRectangle"
add try...catch for rect-iAd
@finscn
Copy link
Contributor Author

finscn commented Mar 7, 2014

the String argument is ugly , maybe create a function for Rect-iAd is a better way.

Ejecta.AdPanel=function(){
return new Ejecta.AdBanner( "rectangle" )
}
new Ejecta.AdPanel();

@finscn
Copy link
Contributor Author

finscn commented Mar 24, 2014

@phoboslab , my game has use this one, I think its no problem.
Could you merge it ?

You can see it in Beside You ( the iAd only displayed in Pause Page and Help Page)
Though, the fill rate of iAd is not 100% , so you couldn't see the iAd every time.

in my case , I used

       var iAd = new Ejecta.AdBanner();
       iAd.alwaysPortrait = true;
       iAd.isAtBottom = false;
       iAd.isAtRight = false;

add click and finsih event,  for tracking  user's click-life
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant