Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deprecated push_redirect to push_navigate #444

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

joshprice
Copy link
Contributor

@joshprice joshprice commented Jun 21, 2024

Removes the following compile time deprecation warnings:

==> phoenix_live_dashboard
Compiling 36 files (.ex)
    warning: Phoenix.LiveView.push_redirect/2 is deprecated. Use push_navigate/2 instead
    │
 21 │         {:ok, push_redirect(socket, to: to)}
    │               ~
    │
    └─ lib/phoenix/live_dashboard/pages/metrics_page.ex:21:15: Phoenix.LiveDashboard.MetricsPage.mount/3
    └─ lib/phoenix/live_dashboard/pages/metrics_page.ex:30:15: Phoenix.LiveDashboard.MetricsPage.mount/3

    warning: Phoenix.LiveView.push_redirect/2 is deprecated. Use push_navigate/2 instead
    │
 41 │     {:ok, push_redirect(socket, to: to)}
    │           ~
    │
    └─ lib/phoenix/live_dashboard/pages/request_logger_page.ex:41:11: Phoenix.LiveDashboard.RequestLoggerPage.mount/3

Upgrade some deps
     warning: Phoenix.LiveView.push_redirect/2 is deprecated. Use push_navigate/2 instead
     │
 291 │       {:noreply, push_redirect(socket, to: to)}
     │                  ~
     │
     └─ lib/phoenix/live_dashboard/page_live.ex:291:18: Phoenix.LiveDashboard.PageLive.handle_event/3
     └─ lib/phoenix/live_dashboard/page_live.ex:369:5: Phoenix.LiveDashboard.PageLive.redirect_to_current_node/1

Removes compile time deprecation warnings
@josevalim josevalim merged commit 5fe566b into phoenixframework:main Jun 21, 2024
3 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@joshprice joshprice deleted the fix-deprecation-warnings branch June 21, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants