Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #295
@atztogo i noticed you don't directly use
in the
build_wheels
steps
. is that by design? i think it could replace your codegit tag v`grep __version__ phono3py/version.py|awk -F'"' '{print($2)}'` python -m cibuildwheel --output-dir wheelhouse
if not and
phono3py
has special requirements i'm unaware of, then what i did (simply adding Windows and macOS to thestrategy.matrix.os
) might not work in which case, feel free to close this PR